Keep workers reconnecting across hub outages#258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
WORKER_DISCONNECTED_TIMEOUT_SconfigurationRoot cause
The worker owned a fixed disconnected lifetime even though the protocol contract requires reconnecting after every non-Drain stream loss. Once that lifetime elapsed, PID 1 exited while the provider pod could remain allocated and appear RUNNING but idle. The live four-minute incident did not reach the old 600-second default, so this removes a proven lifecycle defect without claiming it was the only cause of that event.
Validation
pytest tests/test_drain_flush.py tests/test_token_refresh.py tests/test_worker_grpc_e2e.py: 24 passedmypy src: clean across 114 filesruff check: cleanmasterin this host environmentgit diff --check: clean