feat: declarative worker model residency (protocol v3)#255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contract
DesiredInstance reuses the existing RunJob binding path: function name plus the complete slot-to-immutable-ref map identifies the concrete runnable instance. Same-generation desired state is a valid retry/presigned-URL refresh; only lower generations are stale. Protocol field numbers match the coordinated Tensorhub schema.
This PR must land with the matching Tensorhub protocol-v3 controller change. It should not be merged or released independently.
Validation
The remaining full-suite failure is tests/test_content_lanes.py::test_lane_swap_moves_only_the_exclusive_module. It reproduces in isolation on the current shared GPU: the synthetic 2.3 GiB budget expects acme/a to demote to RAM, but the installed runtime keeps it in VRAM. None of this PR's touched code is on that budgeting/content-lane path.