[TRIVIAL] autopilot-svm: log landed tx signatures as base58 - #4873
Open
tilacog wants to merge 1 commit into
Open
[TRIVIAL] autopilot-svm: log landed tx signatures as base58#4873tilacog wants to merge 1 commit into
tilacog wants to merge 1 commit into
Conversation
Contributor
|
Claude finished @tilacog's task in 36s —— View job PR Review
LGTM. This is a correct, well-scoped change.
No issues to flag. |
squadgazzz
approved these changes
Sep 4, 2026
squadgazzz
left a comment
Contributor
There was a problem hiding this comment.
We need to double check other places. I think today I bumped into other fields with the similar issue.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The autopilot logged landed settlement signatures as hex while the driver logs them as base58, making it hard to correlate the same transaction across the two components' logs.
Changes
tx_signatureviachain_types::solana::Signature(base58 Display) instead ofconst_hex::encodein the "settlement observed on chain" log