Skip to content

[TRIVIAL] autopilot-svm: log landed tx signatures as base58 - #4873

Open
tilacog wants to merge 1 commit into
mainfrom
svm-log-signatures-base58
Open

[TRIVIAL] autopilot-svm: log landed tx signatures as base58#4873
tilacog wants to merge 1 commit into
mainfrom
svm-log-signatures-base58

Conversation

@tilacog

@tilacog tilacog commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Description

The autopilot logged landed settlement signatures as hex while the driver logs them as base58, making it hard to correlate the same transaction across the two components' logs.

Changes

  • autopilot-svm: render tx_signature via chain_types::solana::Signature (base58 Display) instead of const_hex::encode in the "settlement observed on chain" log

@tilacog
tilacog requested a review from a team as a code owner September 4, 2026 18:36
@claude

claude Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Claude finished @tilacog's task in 36s —— View job


PR Review

  • Read the diff and surrounding code
  • Verify Signature type and its base58 Display
  • Check consistency with the driver

LGTM. This is a correct, well-scoped change.

  • landed.submitted_signature is a ByteArray<64>, so .0 is [u8; 64] — exactly what chain_types::solana::Signature(pub [u8; 64]) wraps, and its Display renders base58 (crates/chain-types/src/solana.rs:93). Type-safe, no behavior change beyond the log format.
  • Consistent with the driver DTO, which already types tx_signature as Signature (crates/autopilot-svm/src/infra/driver/dto.rs:142), so signatures now line up across both components' logs as intended.

No issues to flag.
· svm-log-signatures-base58

@squadgazzz squadgazzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to double check other places. I think today I bumped into other fields with the similar issue.

@tilacog
tilacog added this pull request to the merge queue Sep 4, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants