Skip to content

Drop auction_prices table #4852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jmg-duarte wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Draft

Drop auction_prices table #4852

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions database/sql/V124__drop_auction_prices.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
-- Drop the `auction_prices` table. Its data duplicated the `price_tokens` /
-- `price_values` arrays of `competition_auctions`, which every reader now uses.
DROP TABLE IF EXISTS auction_prices;

@claude claude Bot Sep 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocker: the table is still being written to. autopilot's save_competition still inserts into auction_prices on every auction:

  • crates/autopilot/src/database/competition.rs:51 → database::auction_prices::insert(...) → INSERT INTO auction_prices (...) (crates/database/src/auction_prices.rs:26)
  • This runs on the run-loop hot path (crates/autopilot/src/run_loop.rs:642), inside a try_join! whose error is propagated with ?.

Once this migration runs, that INSERT will fail with relation "auction_prices" does not exist, rolling back the whole competition-save transaction and failing post-processing for every auction. Because migrations apply before/independently of the new binary rolling out, this breaks autopilot regardless of deploy ordering.

The write path (insert in crates/database/src/auction_prices.rs and its call site in competition.rs) must be removed before or together with dropping the table.

Also note the deprecation comment in crates/database/src/auction_prices.rs:1-3 states the table "can't currently be removed, since the solver team is still using it." If that's stale, please confirm with the solver team (and any analytics/replica consumers) before dropping — otherwise it's an external breakage too.

@MartinquaXD MartinquaXD Sep 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Why did you decide to apply this change on top of main instead of the PR series that actually removes and refactors the related code?

@jmg-duarte jmg-duarte Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to do a bit of git surgery on the other branches, I was just tired of it so I just took the code out and placed it outside. Eventually it gets merged to main anyway

Loading