update deployment 1.1.0 - #25
Open
kaze-cow wants to merge 3 commits into
Open
Conversation
* use updated wrapper implementations post-audit * add CowWrapperHelpers
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
3 tasks
| create2 = true | ||
| ifExists = "continue" | ||
| salt = "<%= settings.wrapperHelpersSalt %>" | ||
| args = ["<%= settings.cowSettlementAddress %>"] |
Contributor
There was a problem hiding this comment.
shouldn't this be Authenticator, not Settlement, according to the WrapperHelpers' constructor?
## Summary `CowWrapperHelpers` deployments now receive CoW Protocol's Authenticator, so their solver-authorization checks call the contract that implements `isSolver` instead of treating Settlement as the authenticator. This is a focused fix stacked on the deployment release in PR #25. ## Validation - `forge test` — 133 passed, 0 failed, 7 skipped Related: #25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the deployment package for Euler Integration contracts.
Context
CollateralSwapWrapperTesting Instructions
Confirm the cannonfile changes look as expected
Confirm that the build works (tested by CI)
Double check the address deployed for the CowWrapperHelpers matches production expected in the docs PR above.