feat: show scheduled parts in eoa twap - #8119
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughThe TWAP hook now maps unconfirmed part orders as virtual open orders. Tests cover candidate replacement, parent status handling, pagination requests, and final-part detection. ChangesTWAP virtual part handling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Scheduled EOA TWAP parts are now shown as virtual open orders until confirmed, with terminal parent states preserved. The covered behavior presents no remaining merge-blocking risk. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Description checkExplanation The description explains the main change, dependencies, related issue, and includes a screenshot. It does not include the required To Test or Self-checks sections and provides no QA verification steps. ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit maps the TWAP trail, Comment |
e3891eb to
2ec1eb1
Compare
8729a89 to
fbd92f4
Compare
4fb0d51 to
a3b2136
Compare
fbd92f4 to
4d114bc
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
4d114bc to
8af8f69
Compare
Instead of querying only "discrete" parts, now we query candidates as well (scheduled).
Depends on cowprotocol/cow-programmatic-orders-api#7
Depends on cowprotocol/cow-sdk#1002
Part of FE-479 Show Sheduled parts for TWAPs for EOAs
Summary by CodeRabbit