Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for a new counter_eq bounds mode and wires up counter management RPCs so workloads can be bounded by counters that are either decremented (counter) or must remain equal to their initial value (counter_eq).
Changes:
- Introduces
Bounds::CounterEqwith aCounterEqualsBoundsExecutor. - Implements
set_counterandclear_all_countersRPCs and routes bounds parsing for the newcounter_eqtype. - Refactors counter storage to be held on
Performerand shared across runs.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| performer/src/performer.rs | Implements counter RPCs and switches run execution to reuse self.counters. |
| performer/src/counters/counter.rs | Makes Counters Default and adds set()/clear() APIs. |
| performer/src/common/horizontal_scale_runner.rs | Adds parsing for CounterEq bounds and adjusts counter bound creation. |
| performer/src/common/bounds.rs | Adds Bounds::CounterEq and its executor implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Bencher Report| Branch | RSCBC-280-28185361572-178-1 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| query | 📈 view plot 🚷 view threshold | 510.77 µs |
| upsert_and_get | 📈 view plot 🚷 view threshold | 464.55 µs |
|
| Branch | RSCBC-280-28186182996-179-1 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | microseconds (µs) |
|---|---|---|
| query | 📈 view plot 🚷 view threshold | 415.88 µs |
| upsert_and_get | 📈 view plot 🚷 view threshold | 429.63 µs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.