Repository navigation
feat(composer): people and tags mention example, with suggestion list fixes - #927
Open
pasqualevitiello wants to merge 4 commits into
Open
pasqualevitiello wants to merge 4 commits into
pasqualevitiello wants to merge 4 commits into
Conversation
… fixes Add p-composer-13: one mention list with Team members, Contacts and Tags sections, each contact's tags shown as badges, and Shift+Enter or Shift-click to mention several people without closing the list. Composer fixes found while building it: - Suggestions reopen every time the field regains focus with the caret on a query. Blur used to record the query as dismissed, so refocusing alternated between showing and hiding them. - A space closes the suggestions unless a name continues past the word just typed: "@sam " still shows Sam Rivera, "@h " closes. - The popup shrinks to the available height instead of moving to the side of the field. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
pasqualevitiello
enabled auto-merge (squash)
November 19, 2026 15:27
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A new composer example,
p-composer-13, for mentioning people who can carry tags. Everything is one list, with no second step:@news) also finds the people who carry it. Tags move to the top once the query is two or more characters and starts a tag name.Shift+EnterorShift-click mentions the highlighted person and keeps the list open with the same query.Escapethen removes the leftover query.Building it surfaced three composer bugs, fixed here:
@h␣@sam␣@sam rivera␣@Docs: the “Groups of people” section becomes “People and tags”, and the sentence about spaces in queries describes the new rule.
Evidence
Before: on
main, six DOM tests written for these fixes fail: suggestions reopening on every refocus (two tests) and the space rule (four tests).After: the same six tests pass on this branch. The tests are not part of this PR; they were removed before review.
The existing suites pass (
bun test: 47, composer DOM tests: 9), along with type checks forapps/uiandpackages/ui,registry:validate-deps, and the Biome format check.The example and the popup sizing were checked in the browser at desktop and phone widths, in light and dark, including an axe scan of the open list.
Shift-click was exercised with dispatched events only, not with a real mouse.Merge Danger
Door: two-way
No API is removed or renamed.
ActiveQuerygains a requiredspaceAfterfield, andcomposer-querygains acontinuesPastQueryexport thatuse-composer-editornow depends on.Blast Radius: composer
Three behaviour changes reach every composer with suggestions:
showEmpty.Escapeno longer keeps the list closed across a blur: coming back to the field with the caret on a query shows the suggestions again.Known limits of the example, not of the composer: a keep-open pick resets the undo history, clicking away leaves the typed query in the message, there is no keep-open on touch, and a keep-open pick is not announced to screen readers. The two tag dots use raw palette colors (
bg-sky-500,bg-amber-500).#926 also edits
composer-query.ts, so whichever merges second needs a rebase and a registry rebuild.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.