chore(deps): bump @base-ui/react to 1.6.0 and rename OTPFieldPreview to OTPField#801
chore(deps): bump @base-ui/react to 1.6.0 and rename OTPFieldPreview to OTPField#801orielhaim wants to merge 2 commits into
Conversation
|
@orielhaim is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
| "use client"; | ||
|
|
||
| import { OTPFieldPreview as OTPFieldPrimitive } from "@base-ui/react/otp-field"; | ||
| import { OTPField as OTPFieldPrimitive } from "@base-ui/react/otp-field"; |
There was a problem hiding this comment.
🔴 Registry build artifact not regenerated — users get stale OTPFieldPreview import
The source files (apps/ui/registry/default/ui/otp-field.tsx and packages/ui/src/components/otp-field.tsx) were updated to import OTPField from @base-ui/react/otp-field, but the pre-built registry JSON at apps/ui/public/r/otp-field.json was not regenerated. It still contains import { OTPFieldPreview as OTPFieldPrimitive } from "@base-ui/react/otp-field". When users run npx shadcn@latest add @coss/otp-field, they will receive this stale code that references OTPFieldPreview — a named export that no longer exists in @base-ui/react 1.6.0. The component will fail to import at build time. Per apps/ui/CONTRIBUTING.md and apps/ui/AGENTS.md (section 16), bun run registry:build must be run after modifying UI primitives.
Prompt for agents
The pre-built registry JSON file at apps/ui/public/r/otp-field.json still contains the old import statement using OTPFieldPreview. After changing the source import in apps/ui/registry/default/ui/otp-field.tsx from OTPFieldPreview to OTPField, you need to regenerate the registry artifacts by running bun run registry:build from the apps/ui directory. This will update apps/ui/public/r/otp-field.json (and any other generated files) so that the content field reflects the new OTPField import. Without this step, users installing the component via npx shadcn@latest add @coss/otp-field will receive broken code that references a non-existent export from @base-ui/react 1.6.0.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Can you do a review again? |
|
Thanks for your contribution but there are way too many file changes, very hard to review. Closed in favor of #805 |
|
Obviously there are a lot of file changes because you just asked me to build the registry........ |
Base UI 1.6.0 graduates OTP Field out of preview. The namespace export is now
OTPFieldinstead ofOTPFieldPreview. This PR bumps@base-ui/reactto^1.6.0and updates the coss registry component, package source, and docs to use the new name.Changes
@base-ui/reactto1.6.0inapps/uiandpackages/ui.otp-field.tsx(registry + package) to importOTPField as OTPFieldPrimitivefrom@base-ui/react/otp-field.OTPFieldinstead ofOTPFieldPreview, and drop the "preview" note on the component page.react-day-picker,lint-staged, andturbo.