fix(trace): preserve tool outcome certainty - #16
Open
yearth wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A normalized event currently exposes only
isError. When it isfalse, consumers cannot tell whether the tool definitely succeeded or the source log never recorded a final outcome.This extracts the adapter/data-layer part of #14 so mindwalk can preserve that distinction without committing to a Trace Health UI or product contract.
What changed
outcomeKnownevidence to normalized trace events.is_error: falseversus a missingis_errorfield.patch_apply_end.successas a known outcome.The resulting states are:
outcomeKnownisErrortruefalsetruetruefalsefalseoutcomeKnownis optional, so traces produced before this change remain valid under the updated schema. ExistingisError: trueevents still identify failures without the new field.Scope
This PR intentionally does not include session-health derivation, a health API or CLI command, or any UI. It only preserves source evidence in the shared trace model for future consumers such as judge input, comparisons, or metric annotations.
Validation
go test -count=1 ./...go vet ./...make testmindwalk trace testdata/claude-session.jsonlsmoke check confirmedoutcomeKnown: truein exported eventsRelated to #14.