Skip to content

Review GLSL shader modules with CodeRabbit - #268

Merged
rokotyan merged 1 commit into
mainfrom
chore/coderabbit-glsl
Sep 17, 2026
Merged

rokotyan merged 1 commit into
mainfrom
chore/coderabbit-glsl

Conversation

@Stukova

@Stukova Stukova commented Sep 16, 2026

Copy link
Copy Markdown
Member

CodeRabbit skips *.glsl by default (its "Game and 3D assets" list), so point-size.glsl and exit-ramp.glsl went unreviewed on #266 while the .vert / .frag files that include them were reviewed.

reviews:
  path_filters:
    - "**/*.glsl"

The exact pattern without the leading ! lifts the default; a broad include such as src/** does not. CodeRabbit reads the file from the branch under review, so it applies to PRs that contain it.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated code review configuration to include GLSL shader files in automated reviews.

… asset filter

CodeRabbit's built-in ignore list files *.glsl under "Game and 3D
assets", so the shared shader modules (point-size.glsl, exit-ramp.glsl)
went unreviewed while the .vert and .frag files that include them were
reviewed. The exact pattern without the leading "!" lifts that default;
a broad include such as src/** does not.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Stukova Olya <stukova.o@gmail.com>
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 42720a87-189d-4caf-99f8-4ec801c88393

📥 Commits

Reviewing files that changed from the base of the PR and between af9c553 and 297a4df.

📒 Files selected for processing (1)
  • .coderabbit.yaml

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.


📝 Walkthrough

Walkthrough

The new CodeRabbit v2 configuration adds a reviews.path_filters rule for **/*.glsl, which includes GLSL shader files in reviews.

Changes

Shader Review Configuration

Layer / File(s) Summary
GLSL path filter
.coderabbit.yaml
Adds the CodeRabbit v2 schema and configures reviews.path_filters to include **/*.glsl files.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 297a4

This change enables GLSL files to be included in CodeRabbit reviews and is ready to merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: enabling CodeRabbit reviews for GLSL shader modules.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/coderabbit-glsl

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Stukova
Stukova requested a review from rokotyan September 16, 2026 14:31
@rokotyan
rokotyan merged commit 361eeba into main Sep 17, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants