feat(ha): Add per-tenant configurable failover timeout#7481
Open
yeya24 wants to merge 1 commit intocortexproject:masterfrom
Open
feat(ha): Add per-tenant configurable failover timeout#7481yeya24 wants to merge 1 commit intocortexproject:masterfrom
yeya24 wants to merge 1 commit intocortexproject:masterfrom
Conversation
yeya24
force-pushed
the
ha-failover-timeout-per-tenant
branch
2 times, most recently
from
c202aa9 to
5ce8f5f
Compare
Member
|
Why don't you extend the existing |
Contributor
Author
|
Let me rename the new flag to use the same name as |
yeya24
force-pushed
the
ha-failover-timeout-per-tenant
branch
from
5ce8f5f to
7f44369
Compare
yeya24
force-pushed
the
ha-failover-timeout-per-tenant
branch
from
7f44369 to
067b6fb
Compare
Move -distributor.ha-tracker.failover-timeout from HATrackerConfig (global)
to the per-tenant Limits struct. The flag name and default value (30s)
remain the same, but it can now be overridden per-tenant via runtime config:
overrides:
"tenant-1":
ha_tracker_failover_timeout: 60s
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
ha-failover-timeout-per-tenant
branch
from
067b6fb to
af59017
Compare
Contributor
Author
|
Updated to reuse the same config name but make it per tenant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a per-tenant runtime override for the HA tracker failover timeout via the ha_tracker_failover_timeout field in the limits config (flag: -distributor.ha-tracker.failover-timeout-override). When set to a non-zero value for a tenant, it overrides the global -distributor.ha-tracker.failover-timeout.
This allows operators to configure different failover timeouts for different tenants based on their HA setup requirements.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags