Cufft bug

.clang-format

@@ -1,230 +1,74 @@
+# https://clang-format-configurator.site
+# Copyright 2020-2025 Alfredo A. Correa
+# this format specification requires clang-format version 15, it is optimized for clang-format version 19
 ---
-Language:        Cpp
-# BasedOnStyle:  Google
-#AccessModifierOffset: -1
-AlignAfterOpenBracket: BlockIndent  # Align
+Language: Cpp
+AccessModifierOffset: -3
+AlignAfterOpenBracket: BlockIndent
 AlignArrayOfStructures: Right
-#AlignConsecutiveMacros: None
-AlignConsecutiveAssignments: Consecutive  # None
-#AlignConsecutiveBitFields: None
-AlignConsecutiveDeclarations: Consecutive
-#AlignEscapedNewlines: Left
-AlignOperands:   AlignAfterOperator
-AlignTrailingComments: false
-#AllowAllArgumentsOnNextLine: true
-#AllowAllParametersOfDeclarationOnNextLine: true
-#AllowShortEnumsOnASingleLine: true
-#AllowShortBlocksOnASingleLine: Never
-AllowShortCaseLabelsOnASingleLine: true  # false
-#AllowShortFunctionsOnASingleLine: All
-#AllowShortLambdasOnASingleLine: All
-#AllowShortIfStatementsOnASingleLine: WithoutElse
-#AllowShortLoopsOnASingleLine: true
-#AlwaysBreakAfterDefinitionReturnType: None
-#AlwaysBreakAfterReturnType: None
-#AlwaysBreakBeforeMultilineStrings: true
-AlwaysBreakTemplateDeclarations: No  # Yes
-#AttributeMacros:
-#  - __capability
-#BinPackArguments: true
-#BinPackParameters: true
-#BraceWrapping:
-#  AfterCaseLabel:  false
-#  AfterClass:      false
-#  AfterControlStatement: Never
-#  AfterEnum:       false
-#  AfterFunction:   false
-#  AfterNamespace:  false
-#  AfterObjCDeclaration: false
-#  AfterStruct:     false
-#  AfterUnion:      false
-#  AfterExternBlock: false
-#  BeforeCatch:     false
-#  BeforeElse:      false
-#  BeforeLambdaBody: false
-#  BeforeWhile:     false
-#  IndentBraces:    false
-#  SplitEmptyFunction: true
-#  SplitEmptyRecord: true
-#  SplitEmptyNamespace: true
-#BreakBeforeBinaryOperators: None
-#BreakBeforeConceptDeclarations: true
-#BreakBeforeBraces: Attach
-#BreakBeforeInheritanceComma: false
+AlignConsecutiveAssignments:
+  Enabled: true
+  AcrossEmptyLines: false
+  AcrossComments: false
+AlignConsecutiveDeclarations:
+  Enabled: true
+  AcrossEmptyLines: false
+  AcrossComments: false
+AlignConsecutiveMacros: None
+AlignOperands: AlignAfterOperator
+AllowAllArgumentsOnNextLine: false
+AllowShortLambdasOnASingleLine: All
+AllowShortCaseLabelsOnASingleLine: true
+AlwaysBreakTemplateDeclarations: No
+# BreakConstructorInitializers: BeforeComma
 BreakInheritanceList: BeforeComma
-#BreakBeforeTernaryOperators: true
-#BreakConstructorInitializersBeforeComma: false
-#BreakConstructorInitializers: BeforeColon
-#BreakAfterJavaFieldAnnotations: false
-#BreakStringLiterals: true
-ColumnLimit:     0
-#CommentPragmas:  '^ IWYU pragma:'
-QualifierAlignment: Right  # Leave
-#CompactNamespaces: false
+BraceWrapping:
+  BeforeLambdaBody: false
+ColumnLimit: 0
+QualifierAlignment: Right
 ConstructorInitializerIndentWidth: 0
-ContinuationIndentWidth: 99
-#Cpp11BracedListStyle: true
-#DeriveLineEnding: true
-#DerivePointerAlignment: true
-#DisableFormat:   false
-#EmptyLineAfterAccessModifier: Never
-#EmptyLineBeforeAccessModifier: LogicalBlock
-#ExperimentalAutoDetectBinPacking: false
-#PackConstructorInitializers: NextLine
-#BasedOnStyle:    ''
-#ConstructorInitializerAllOnOneLineOrOnePerLine: false
-#AllowAllConstructorInitializersOnNextLine: true
+ContinuationIndentWidth: 4
+Cpp11BracedListStyle: true
 FixNamespaceComments: true
-#ForEachMacros:
-#  - foreach
-#  - Q_FOREACH
-#  - BOOST_FOREACH
-#IfMacros:
-#  - KJ_IF_MAYBE
-#IncludeBlocks:   Regroup
-#IncludeCategories:
-#  - Regex:           '^<ext/.*\.h>'
-#    Priority:        2
-#    SortPriority:    0
-#    CaseSensitive:   false
-#  - Regex:           '^<.*\.h>'
-#    Priority:        1
-#    SortPriority:    0
-#    CaseSensitive:   false
-#  - Regex:           '^<.*'
-#    Priority:        2
-#    SortPriority:    0
-#    CaseSensitive:   false
-#  - Regex:           '.*'
-#    Priority:        3
-#    SortPriority:    0
-#    CaseSensitive:   false
-#IncludeIsMainRegex: '([-_](test|unittest))?$'
-#IncludeIsMainSourceRegex: ''
-#IndentAccessModifiers: true  # false
-AccessModifierOffset: -98  # 2
-#IndentCaseLabels: true
-#IndentCaseBlocks: false
-#IndentGotoLabels: true
+IncludeBlocks: Regroup
+IncludeCategories:
+  - Regex: <(boost\/multi)\/
+    Priority: 1
+  - Regex: <([A-Za-z0-9\Q/-_\E])+>
+    Priority: 5
+  - Regex: <(boost)\/
+    Priority: 4
+  - Regex: <([A-Za-z0-9.\Q/-_\E])+>
+    Priority: 3
+  - Regex: '"([A-Za-z0-9.\Q/-_\E])+"'
+    Priority: 2
+#IndentPPDirectives: Leave
 #IndentPPDirectives: None
-#IndentExternBlock: AfterExternBlock
-#IndentRequires:  false
-IndentWidth:     99
-#IndentWrappedFunctionNames: false
-#InsertTrailingCommas: None
-#JavaScriptQuotes: Leave
-#JavaScriptWrapImports: true
-#KeepEmptyLinesAtTheStartOfBlocks: false
-#LambdaBodyIndentation: Signature
-#MacroBlockBegin: ''
-#MacroBlockEnd:   ''
-#MaxEmptyLinesToKeep: 1
-#NamespaceIndentation: None
-#ObjCBinPackProtocolList: Never
-#ObjCBlockIndentWidth: 2
-#ObjCBreakBeforeNestedBlockParam: true
-#ObjCSpaceAfterProperty: false
-#ObjCSpaceBeforeProtocolList: true
-#PenaltyBreakAssignment: 2
-#PenaltyBreakBeforeFirstCallParameter: 1
-#PenaltyBreakComment: 300
-#PenaltyBreakFirstLessLess: 120
-#PenaltyBreakOpenParenthesis: 0
-#PenaltyBreakString: 1000
+IndentWidth: 4
+# LambdaBodyIndentation: Signature
+# OneLineFormatOffRegex: ^(\#ifdef|\#endif)  # for clang-format version 21
+# PackConstructorInitializers: CurrentLine
 PenaltyBreakTemplateDeclaration: 10
-#PenaltyExcessCharacter: 1000000
-#PenaltyReturnTypeOnItsOwnLine: 200
-#PenaltyIndentedWhitespace: 0
 PointerAlignment: Left
-#PPIndentWidth:   -1
-#RawStringFormats:
-#  - Language:        Cpp
-#    Delimiters:
-#      - cc
-#      - CC
-#      - cpp
-#      - Cpp
-#      - CPP
-#      - 'c++'
-#      - 'C++'
-#    CanonicalDelimiter: ''
-#    BasedOnStyle:    google
-#  - Language:        TextProto
-#    Delimiters:
-#      - pb
-#      - PB
-#      - proto
-#      - PROTO
-#    EnclosingFunctions:
-#      - EqualsProto
-#      - EquivToProto
-#      - PARSE_PARTIAL_TEXT_PROTO
-#      - PARSE_TEST_PROTO
-#      - PARSE_TEXT_PROTO
-#      - ParseTextOrDie
-#      - ParseTextProtoOrDie
-#      - ParseTestProto
-#      - ParsePartialTestProto
-#    CanonicalDelimiter: pb
-#    BasedOnStyle:    google
-#ReferenceAlignment: Pointer
-#ReflowComments:  true
-#RemoveBracesLLVM: false
-#SeparateDefinitionBlocks: Leave
-#ShortNamespaceLines: 1
-#SortIncludes:    CaseSensitive
-#SortJavaStaticImport: Before
-#SortUsingDeclarations: true
-#SpaceAfterCStyleCast: false
-#SpaceAfterLogicalNot: false
-SpaceAfterTemplateKeyword: false # true
-#SpaceBeforeAssignmentOperators: true
-#SpaceBeforeCaseColon: false
-#SpaceBeforeCpp11BracedList: false
-#SpaceBeforeCtorInitializerColon: true
-#SpaceBeforeInheritanceColon: true
-SpaceBeforeParens: Custom  # ControlStatements
+ReferenceAlignment: Left
+SpaceAfterTemplateKeyword: false
+SpaceBeforeAssignmentOperators: true
+SpaceBeforeParens: Custom
 SpaceBeforeParensOptions:
-  AfterControlStatements: false  # true
-#  AfterForeachMacros: true
-#  AfterFunctionDefinitionName: false
-#  AfterFunctionDeclarationName: false
-#  AfterIfMacros:   true
-#  AfterOverloadedOperator: false
-#  BeforeNonEmptyParentheses: false
-#SpaceAroundPointerQualifiers: Default
-#SpaceBeforeRangeBasedForLoopColon: true
-#SpaceInEmptyBlock: false
-#SpaceInEmptyParentheses: false
+  AfterControlStatements: false
+  AfterForeachMacros: false
+  AfterFunctionDeclarationName: false
+  AfterFunctionDefinitionName: false
+  AfterIfMacros: false  # AfterNot: false
+  AfterOverloadedOperator: false  # AfterPlacementOperator: false
+  AfterRequiresInClause: false
+  AfterRequiresInExpression: false
+  BeforeNonEmptyParentheses: false
 SpacesBeforeTrailingComments: 2
-#SpacesInAngles:  Never
-#SpacesInConditionalStatement: false
-#SpacesInContainerLiterals: true
-#SpacesInCStyleCastParentheses: false
 SpacesInLineCommentPrefix:
-  Minimum:         1
-#  Maximum:         -1
-#SpacesInParentheses: false
-#SpacesInSquareBrackets: false
-#SpaceBeforeSquareBrackets: false
-#BitFieldColonSpacing: Both
-Standard:         c++17
-#StatementAttributeLikeMacros:
-#  - Q_EMIT
-#StatementMacros:
-#  - Q_UNUSED
-#  - QT_REQUIRE_VERSION
-TabWidth:        99
-#UseCRLF:         false
-UseTab:         ForContinuationAndIndentation  # Never
+  Minimum: 1
+Standard: c++17
+TabWidth: 4
+UseTab: ForContinuationAndIndentation
 WhitespaceSensitiveMacros:
-  - BOOST_REQUIRE
   - BOOST_TEST
-  - BOOST_TEST_REQUIRE
-#WhitespaceSensitiveMacros:
-#  - STRINGIZE
-#  - PP_STRINGIZE
-#  - BOOST_PP_STRINGIZE
-#  - NS_SWIFT_NAME
-#  - CF_SWIFT_NAME
-...

.clang-tidy

@@ -1,47 +1,64 @@
-# -*-indent-tabs-mode:nil;c-basic-offset:2;tab-width:2;autowrap:nil;-*-
+# Copyright 2020-2025 Alfredo A. Correa
 
 WarningsAsErrors: '*'
 HeaderFilterRegex: '.'
 FormatStyle: file
+TransformLambdas: none
 
 CheckOptions:
-  - { key: readability-identifier-naming.ClassCase                   , value: lower_case }
-  - { key: readability-identifier-naming.FunctionCase                , value: lower_case }
-  - { key: readability-identifier-naming.GlobalConstantCase          , value: aNy_CasE   }
-  - { key: readability-identifier-naming.NamespaceCase               , value: lower_case }
-  - { key: readability-identifier-naming.PrivateMemberPrefix         , value: ''         }
-  - { key: readability-identifier-naming.PrivateMemberSufix          , value: _          }
-  - { key: readability-identifier-naming.StructCase                  , value: lower_case }
-  - { key: readability-identifier-naming.TemplateParameterCase       , value: CamelCase  }
-  - { key: readability-identifier-length.MinimumLoopCounterNameLength, value: 2          }
-  - { key: readability-identifier-length.MinimumParameterNameLength  , value: 2          }
-  - { key: readability-identifier-length.MinimumVariableNameLength   , value: 2          }
-  - { key: readability-identifier-length.IgnoredLoopCounterNames     , value: "^[ijk_]$" }
-  - { key: readability-identifier-length.IgnoredVariableNames        , value: "^[ijk]$"  }
-  - { key: readability-identifier-naming.GlobalConstantCase          , value: aNy_CasE   }
-  - { key: readability-identifier-naming.PrivateMemberSufix          , value: _          }
-
-# for range-for loops, e.g. `for(auto i : is) ...`
-#  - { key: readability-identifier-length.IgnoredVariableNames        , value: "^[ijk]$"  }
+  - { key: readability-identifier-naming.ClassCase                         , value: lower_case }
+  - { key: readability-identifier-naming.FunctionCase                      , value: lower_case }
+  - { key: readability-identifier-naming.GlobalConstantCase                , value: aNy_CasE   }
+  - { key: readability-identifier-length.IgnoredLoopCounterNames           , value: "^[ijk_]$" }
+  - { key: readability-identifier-length.IgnoredParameterNames             , value: "^[xyzabcdnml]$" }
+  - { key: readability-identifier-length.IgnoredVariableNames              , value: "^[ijk_]$" }
+  - { key: readability-identifier-length.MethodCase                        , value: lower_case }
+  - { key: readability-identifier-length.MinimumLoopCounterNameLength      , value: 2          }
+  - { key: readability-identifier-length.MinimumParameterNameLength        , value: 2          }
+  - { key: readability-identifier-length.MinimumVariableNameLength         , value: 2          }
+  - { key: readability-identifier-naming.NamespaceCase                     , value: lower_case }
+  - { key: readability-identifier-naming.PrivateMemberPrefix               , value: ''         }
+  - { key: readability-identifier-naming.PrivateMemberSuffix               , value: _          }
+  - { key: readability-identifier-naming.PrivateMethodSuffix               , value: _          }
+  - { key: readability-identifier-naming.StructCase                        , value: lower_case }
+  - { key: readability-identifier-naming.TemplateParameterCase             , value: CamelCase  }
+  - { key: readability-identifier-naming.TypeTemplateParameterIgnoredRegexp, value: expr-type}
+  - { key: readability-operators-representation.BinaryOperators            , value: '&&;&=;&;|;~;!;!=;||;|=;^;^='}
+# value: expr-type , bug in clang 16 in c++20 mode https://stackoverflow.com/a/75157215/225186
 
 Checks: '*,
   -altera-struct-pack-align,
+  -boost-use-ranges,
+  -cert-dcl21-cpp,
   -cppcoreguidelines-avoid-magic-numbers,
   -cppcoreguidelines-macro-usage,
+  -cppcoreguidelines-pro-bounds-avoid-unchecked-container-access,
+  -fuchsia-default-arguments-calls,
+  -fuchsia-statically-constructed-objects,
   -fuchsia-overloaded-operator,
   -fuchsia-trailing-return,
+  -hicpp-no-array-decay,
+  -llvm-prefer-static-over-anonymous-namespace,
   -llvmlibc-*,
   -modernize-use-nodiscard,
-  -readability-magic-numbers
-'
+  -modernize-use-trailing-return-type,
+  -readability-magic-numbers,
+  -readability-simplify-boolean-expr'
 
 ## explanation of the suppressed rules above:
 #  -altera-struct-pack-align,                             // this asks to use non-standard pragmas such as __attribute__((aligned(0))) and _attribute__((packed)), may interfeere with gcc/nvcc compatibility?
+#  -boost-use-ranges                                      // would introduce a dependency on Boost
+#  -cert-dcl21-cpp                                        // this asks postfix operator++ to return a const value
 #  -cppcoreguidelines-avoid-magic-numbers,                // all tests use magic numbers
 #  -cppcoreguidelines-macro-usage,                        // BLAS adaptors uses a lot of macros
+#  -cppcoreguidelines-pro-bounds-avoid-unchecked-container-access  // tests use magic numbers
+#  -fuchsia-statically-constructed-objects,               // used for traits, is_const_subarray
+#  -fuchsia-default-arguments-calls,                      // this library uses STL functions, which use default arguments
 #  -fuchsia-overloaded-operator,                          // this library overloads operators (==, <, +, &)
-#  -fuchsia-trailing-return,                              // to allow any '-> decltype(auto)', contradicts modernize trailing
+#  -hicpp-no-array-decay,                                 // for Boost Lightweight Test
+#  -llvm-prefer-static-over-anonymous-namespace,          // contradicts other rules
 #  -llvmlibc-*,                                           // nonsense warnings, for llvm developers
 #  -modernize-use-nodiscard,                              // this would add [[nodiscard]] to almost all functions, adding a lot of noise
-#  -readability-magic-numbers,                            // all tests use magic numbers
-
+#  -modernize-use-trailing-return-type,                   // mandates all lambdas end with -> auto
+#  -readability-magic-numbers,                            // many tests use magic numbers
+#  -readability-simplify-boolean-expr,                    // for Boost Lightweight Test BOOST_TEST

.deepsource.toml

@@ -0,0 +1,9 @@
+version = 1
+
+test_patterns = ["test/**"]
+
+[[analyzers]]
+name = "test-coverage"
+
+[[analyzers]]
+name = "cxx"