Delete USEEIO-recreation flags without ongoing consumers - #555
Delete USEEIO-recreation flags without ongoing consumers#555briantobin-99 wants to merge 1 commit into
Conversation
I'm making sure we have a record of the margins analysis output linked to a git commit which we can store internally so we have the analysis...i will open up a PR with updates i made to be able to run it off main; store the outputs on GDrive, then I am fine with deleting the margins analysis code and configs stated in this PR, as long as the team is happy with the record of output being enough data/visuals to explain margin changes from useeio and ceda. |
d1d0537 to
43087d3
Compare
|
FYI @briantobin-99 please review and pull this one in before merging this. Otherwise I am good with this one. |
…rs (option PR) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
43087d3 to
1c914fb
Compare
cc:
Closes:
What changed? Why?
Deletes the USEEIO-recreation flags that have no remaining consumer, plus their gated code:
use_ghg_national_2023_m2— the m2 FBS path, the output-weighted NAICS→BEA mapping, and the CH4-GWP-27.9 workbook override. The electricity NAICS retargeting hook in the standard mapping path is untouched.useeio_margins— the USEEIOR margin filter set andinflation_helpers_useeio.py(the USEEIOR CPI table).get_rho_inflation_ratiostays (the publish Excel Rho panel uses it).ceda_margins— the legacy CEDA filter set andderive_2017_margins_ceda_usa/derive_phi_ceda_usa.use_useeio_schema— read by no code; its only effect was the m2 validator interlock.Kept:
scale_a_matrix_with_useeio_method,use_E_data_year_for_x_in_B, anddeflate_x_to_detail_io_year_for_Bremain in use as diagnostic probes by the electricity-disaggregation work (year_alignment_bly_e.py, the electricity configs, and the mixed-units handling inside theD/N_new_inflatedblock), so they are out of scope here.Configs deleted:
useeio_phoebe_23.yamlandv03_waterfall_useeio_g1_schema_ghg.yaml— both set the deleted margins/m2 flags; the USEEIO-track waterfall sheets stay pinned in the registry, and the CEDA-track waterfall configs are untouched.Margins comparison scripts:
compare_margin_approachesandcompare_phi_to_reference(studies of the settled margins decision) are deleted, with an archived output run stored externally as the record. The twocompare_sef_*scripts are kept on pinned inputs:--phoebe-sef-csvis now required (a phoebe SEF published before this merges serves as the pin), andcompare_sef_zenodo_useeio_codedefaults to2025_usa_cornerstone_v0_3.Testing
Unit suite, black, ruff, and mypy green. None of the deleted paths are active in the v0.3 config; Snapshot integration suite (test_integration run) passes on the stack including this change.