Skip to content

Delete A-scaling alternatives, nowcast, and time-series analysis - #552

Open
briantobin-99 wants to merge 1 commit into
btobin__delete-settled-experimental-flagsfrom
btobin__delete-a-approach-alternatives
Open

Delete A-scaling alternatives, nowcast, and time-series analysis#552
briantobin-99 wants to merge 1 commit into
btobin__delete-settled-experimental-flagsfrom
btobin__delete-a-approach-alternatives

Conversation

@briantobin-99

@briantobin-99 briantobin-99 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

cc:
Closes:

What changed? Why?

The A-matrix approach comparison is settled — v0.3 shipped the CEDA-fallback approach — so the alternative A-scaling branches and their analysis harness are removed:

  • Delete scale_a_matrix_with_summary_tables, scale_a_matrix_with_commodity_price_index, load_useeio_nowcast_A_matrix, and apply_inflation_to_V from USAConfig, and their branches in derive_cornerstone_Aq_scaled / derive_cornerstone_q / derive_cornerstone_Vnorm_scrap_corrected / get_vnorm_adjusted_commodity_price_ratio.
  • Delete the nowcast modules (transform/eeio/derived_useeio_nowcast.py, extract/iot/useeio_nowcast.py) — reachable only via the deleted flag.
  • Delete analysis/a_matrix_time_series/ (22 modules including dispatch_ef_time_series and the nowcast runbook), the run_a_matrix_analysis CI workflow, and the nine approach configs (2025_usa_cornerstone_A_*, v0_2_A_*, 2025_usa_cornerstone_taxonomy).
  • test_summary_a_realigned.py tested the deleted summary-tables branch — removed.
  • The two .claude/skills EF-diagnostics skills drop their references to the deleted epic tooling; generic dispatch/plot flows are unchanged.

After this, derive_cornerstone_Aq_scaled has three branches: the USEEIO method, the CEDA fallback (v0.3), and the legacy tail. analysis/a_matrix_bundle_effect and analysis/time_series_B_matrix are untouched (independent of the deleted flags).

Testing

Unit suite, black, ruff, and mypy green. None of the deleted branches are active in the v0.3 config; Snapshot integration suite (test_integration run) passes on the stack including this change.

@bl-young bl-young added the cleanup Code to be cleaned up label Jul 30, 2026
@briantobin-99
briantobin-99 force-pushed the btobin__delete-a-approach-alternatives branch from 9443f88 to 8de3d90 Compare July 30, 2026 18:52
…s analysis

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@briantobin-99
briantobin-99 force-pushed the btobin__delete-a-approach-alternatives branch from 8de3d90 to f3a4fa2 Compare July 30, 2026 23:56
@briantobin-99
briantobin-99 marked this pull request as ready for review July 31, 2026 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Code to be cleaned up

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants