Delete settled experimental flags and dead GHG/waste fields - #551
Open
briantobin-99 wants to merge 1 commit into
Open
Delete settled experimental flags and dead GHG/waste fields#551briantobin-99 wants to merge 1 commit into
briantobin-99 wants to merge 1 commit into
Conversation
briantobin-99
force-pushed
the
btobin__delete-settled-experimental-flags
branch
from
July 30, 2026 18:52
dec205e to
1c0b4bd
Compare
…ields Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
briantobin-99
force-pushed
the
btobin__delete-settled-experimental-flags
branch
from
July 30, 2026 23:56
1c0b4bd to
c34ae03
Compare
briantobin-99
marked this pull request as ready for review
July 30, 2026 23:59
Member
|
This generally looks right to me. I welcome a quick review by @WesIngwersen or @jvendries as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc:
Closes:
What changed? Why?
Removes five
USAConfigflags whose methodology experiments are settled or that no code reads, plus their gated code:use_scaled_x_and_scaled_Vnorm_for_Bandget_q_from_authoritative_x— the A-vs-B x-consistency experiments. Deletes their branches inderive_cornerstone_x_after_redefinition/derive_cornerstone_Vnorm_scrap_corrected/derive_cornerstone_Aq_scaled/derive_cornerstone_B_non_finetuned, thescale_cornerstone_{x,V,B}year-scalers,inflate_cornerstone_B_matrix_with_industry_pi,adjust_summary_{x,V}_dollar_year, and the authoritative-x/deflated-q helpers.derive_cornerstone_x_after_redefinitionbecomes the single, unconditional x pathway.usa_ghg_methodologyandskip_scrap_adjustment_in_vnorm— read by no code at all (the scrap correction always runs; configs that set the skip flag were silent no-ops).eeio_waste_disaggregation— unused weights-override hook; the only setters were test fixtures duplicating the bundled default byte-for-byte.EEIOWasteDisaggConfigmoves towaste_weight_config.py, where it remains the weights-descriptor type for the bundled/USEEIOR paths.Also deletes the completed
reconciling_data_yearsstudy (analysis package + its four configs; recovery point: thereconciling_data_years_finaltag),full_model_scaling_for_A_and_B.yaml,compare_x_approaches.py, andanalysis/q(itscompare_alt_qexists to exercise the deleted q helpers).Testing
Unit suite, black, ruff, and mypy green. None of the deleted branches are active in the v0.3 config; Snapshot integration suite (test_integration run) passes on the stack including this change.