fix: unblock CI — allow clippy::result_large_err on projects_get - #422
Open
byte-the-bot wants to merge 1 commit into
Open
fix: unblock CI — allow clippy::result_large_err on projects_get#422byte-the-bot wants to merge 1 commit into
byte-the-bot wants to merge 1 commit into
Conversation
`main` has been red on Lint since the stable toolchain floated to clippy 1.98, which enforces `result_large_err` here. It went unnoticed because main has not run Rust CI since 2026-08-08 — but every open PR picks it up, so the whole repo's CI is currently blocked on it. Clippy's suggested fix (box the error) is not available: `Err` is an axum `Response`, ~128 bytes by construction, and axum requires the handler error type to implement `IntoResponse`. `Response` is already the canonical one, so the allow is the correct resolution rather than a suppression of a real problem. Reproduced on a clean checkout of main with clippy 0.1.98 and verified `cargo clippy --all-targets -- -D warnings` is clean after the change. This is the only site with the pattern in the workspace. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainis currently red on Lint, and it's blocking every open PRFound while reviewing #398. That PR's Lint job failed on a file it doesn't touch:
projects.rsis byte-for-byte identical onmainand on that branch, so this isn't PR-specific. I reproduced it on a clean checkout ofmainwith clippy 0.1.98 — the same version CI resolves:Why nobody noticed:
main's last Rust CI run was 2026-08-08.actions-rust-lang/setup-rust-toolchain@v1tracks stable, stable moved to 1.98 (2026-08-18), andresult_large_errstarted firing here. Nothing has re-run onmainsince, so the breakage only shows up on PRs — where it reads as "your PR broke Lint."The fix
#[allow(clippy::result_large_err)]on the one handler with this shape.Clippy's suggested remedy (box the error) isn't available here:
Erris an axumResponse, which is ~128 bytes by construction, and axum requires the handler's error type to implementIntoResponse—Responseis already the canonical one. So this is a genuine false positive for the axum handler pattern, not a real problem being papered over.It's the only site in the workspace with this signature:
Verified
cargo fmt --all -- --checkandcargo clippy --all-targets -- -D warningsboth clean on a clean checkout ofmainwith this change applied, using clippy 0.1.98.Suggested follow-up (not in this PR)
A floating toolchain means this recurs on every clippy release, and it stays invisible until someone opens a PR. Either pin the toolchain via
rust-toolchain.toml, or schedule the Rust CI workflow onmainso drift surfaces onmaininstead of ambushing contributors.🤖 Generated with Claude Code