Skip to content

fix(harness): classify pi terminal outcomes honestly - #2345

Open
coreplane-switchboard[bot] wants to merge 1 commit into
mainfrom
plan/fix-p0-https-github-com-40cbdb/u1
Open

coreplane-switchboard[bot] wants to merge 1 commit into
mainfrom
plan/fix-p0-https-github-com-40cbdb/u1

Conversation

@coreplane-switchboard

Copy link
Copy Markdown
Contributor

Requested by justin · Thread

Pi terminal results now preserve local cancellation, unknown outcomes, provider refusal, and provider failures as separate types. Runs no longer invent a permanent provider refusal when pi retained no such evidence.

#2340 showed two coding runs ending together on pi-local aborts but rendered as provider refusals. The truthful fix belongs at the pi terminal boundary.

Rendered by the plan runner from the coding run's submitted description; the run ended before it could open the pull request itself.

Co-Authored-By: coreplane-switchboard[bot] <318072483+coreplane-switchboard[bot]@users.noreply.github.com>

@coreplane-switchboard coreplane-switchboard Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested: The runtime distinction is sound, but two covering behavioral specs still promise the superseded ProviderFailure-only behavior.

Warning

Changes requested · head 5458e8b · 2 findings: 2 minor

Severity Finding Where
minor F1 Spec contradiction — docs/reference/specs/harness.md item 1: local and unknown terminal results no longer cross as ProviderFailure docs/reference/specs/harness.md:11
minor F2 Spec contradiction — docs/reference/specs/harness-pi.md item 6: a client-side abort is now local-only, not provider-down docs/reference/specs/harness-pi.md:16
Full review

F1 — harness.md still states that every failed model answer crosses as a ProviderFailure.cause. The new local_abort and unknown variants deliberately do not, leaving the harness contract and its validation criterion false. Update item 1 to describe the discriminated terminal-result boundary.

F2 — harness-pi.md item 6 still says an ordinary client-side abort is a provider-down failure that may be released by provider-up. The implementation now correctly records it as local cancellation and excludes provider-up release. Coordinate with #1625 so the held spec and its validation rows are updated before this behavior merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant