fix(providers): split parked and terminal failures - #2198
Merged
justinhelmer merged 1 commit intoSep 22, 2026
Merged
Conversation
Co-Authored-By: coreplane-switchboard[bot] <318072483+coreplane-switchboard[bot]@users.noreply.github.com>
coreplane-switchboard
Bot
requested a review
from justinhelmer
as a code owner
September 22, 2026 07:59
coreplane-switchboard Bot
added a commit
that referenced
this pull request
Sep 22, 2026
Co-authored-by: justinhelmer <1403438+justinhelmer@users.noreply.github.com> Co-authored-by: coreplane-switchboard[bot] <318072483+coreplane-switchboard[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates recoverable provider outages from failures that must end immediately, while preserving operator diagnostics and safe requester wording. One-shot CLI asks now fail with exit 1 instead of silently succeeding.
Why: PR #2195 exposed four branch-local CI regressions while implementing issue #2170. The fix preserves record 0075's typed seam without erasing operator context or parking permanent failures.
Where to look
Feedback wanted: Please check the no-run request-failure signal and confirm the matrix's three park causes versus five terminal causes match every consumer.
Risk: The split affects provider errors at the operator and CLI boundaries. A wrong signal can change process status; rollback is this single commit. The executor required a stacked branch because PR #2195's head is this run's protected base.
Verified: Eight focused files (521 tests), root TypeScript, changed-file ESLint/Prettier, docs, hygiene, and specs checks passed; CI remains the final gate.
Decisions (3)
Validation (6 criteria)
npx vitest run src/config.test.ts src/cli.ask.test.ts src/cli.test.ts src/core/providerConformance.test.ts ...passed: 8 files, 521 tests.NODE_OPTIONS=--max-old-space-size=6144 npx tsc --noEmit -p tsconfig.jsonpassed with no output.npx eslintover the 10 changed TypeScript files passed with no output.npm run docs:genwrote design-decisions.md;npm run docs:checkpassed: 12 files match.npx prettier --check,npm run hygiene:check, andnpm run specs:checkall passed.npm run check:pr-title -- "fix(providers): split parked and terminal failures"passed.For agents
Head 0c53bb5 is rebased on origin/main 714dbd3. Direct pushes to fix/provider-failure-seam were refused twice because that ref is this run's protected PR target, so this commit was pushed to fix/provider-failure-seam-ci as a stacked fix. PR #2195 itself remains at be89b85 until this stack lands. No generated file was hand-edited; docs/explanation/design-decisions.md came from npm run docs:gen.
Requested by @justinhelmer in slack:C0BRRHKFLCB
🤖 Generated with Claude Code