chore(deps): bump mermaid from 11.17.2 to 12.0.0 - #2177
dependabot[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Changes requested: Mermaid 12 raises the docs runtime floor beyond the workspace's declared Node support.
Warning
Changes requested · head f2244c9 · 1 finding: 1 minor
| Severity | Finding | Where |
|---|---|---|
| minor | F1 Align the docs Node engine with Mermaid 12 | docs/package.json:20 |
Full review
F1 (minor, high confidence): Mermaid 12 and its parser require Node >=22.12.0, but this workspace still advertises support for all Node 22 releases via "node": ">=22". Installs using Node 22.0–22.11 can fail engine enforcement or run an unsupported dependency. Raise the docs engine floor to >=22.12.0, or keep Mermaid 11.
f2244c9 to
fbe10aa
Compare
Bumps [mermaid](https://github.com/mermaid-js/mermaid) from 11.17.2 to 12.0.0. - [Release notes](https://github.com/mermaid-js/mermaid/releases) - [Commits](https://github.com/mermaid-js/mermaid/compare/mermaid@11.17.2...mermaid@12.0.0) Co-Authored-By: coreplane-switchboard[bot] <318072483+coreplane-switchboard[bot]@users.noreply.github.com> --- updated-dependencies: - dependency-name: mermaid dependency-version: 12.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
fbe10aa to
f546945
Compare
There was a problem hiding this comment.
Changes requested: Mermaid 12 changes the site's diagram layout and appearance because the renderer does not preserve the prior defaults.
Warning
Changes requested · head f546945 · 1 finding: 1 minor
| Severity | Finding | Where |
|---|---|---|
| minor | F1 Spec contradiction — docs-site.md item 19: Mermaid 12 replaces the promised diagram presentation | docs/package.json:20 |
Full review
F1 — Mermaid 12 defaults flowcharts to the neo appearance and ELK layout, while MermaidDiagram.vue leaves look and layout unset. Existing diagrams will gain new styling and layouts, contradicting docs-site item 19’s visual-system contract. Preserve the current presentation by initializing Mermaid with look: "classic" and layout: "dagre", or update the visual contract if the change is intentional.
|
Closing: mermaid 12 is a breaking upgrade for us on two counts. It raises the required Node floor to 22.12.0, which this branch had already fixed, and its review then found that it changes the docs site's diagram layout and appearance because the new renderer does not preserve the previous defaults. Restoring those defaults is design work on the docs site, and we are draining to a clean slate with nothing new added. Dependabot will raise mermaid 12 again, and we take it then together with the default restoration and fresh screenshots. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps mermaid from 11.17.2 to 12.0.0.
Release notes
Sourced from mermaid's releases.
... (truncated)
Commits
98a0945Merge pull request #8237 from mermaid-js/changeset-release/master96be564Version Packagesdd65cfdMerge pull request #8239 from mermaid-js/bug/appearance-docs-release-version-...e1cc7c2fix(tests): accept a released version in the appearance docs marker8382837Merge pull request #8211 from mermaid-js/release/12.0.08a90389ci: trigger a preview publish01b8590ci: attempt every preview package before failing the publish step1997a23ci: record why the preview publish of layout-elk and tiny is refused0304007ci: drop --access public from the preview publish of layout-elk and tiny223be92docs: capitalize Markdown in README taglineDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)