Skip to content

select improvements#2257

Draft
hextion wants to merge 15 commits into
masterfrom
feat/select-improvements
Draft

select improvements#2257
hextion wants to merge 15 commits into
masterfrom
feat/select-improvements

Conversation

@hextion

@hextion hextion commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f8deb80

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Bundle size report

Entry point Size (minified)
@alfalab/core-components-custom-picker-button/index.js 246.4 (-3.00 KB ✅)
@alfalab/core-components-custom-picker-button/desktop/index.js 139.5 (-3.00 KB ✅)
@alfalab/core-components-custom-picker-button/mobile/index.js 218.9 (-3.00 KB ✅)
@alfalab/core-components-input-autocomplete/index.js 251.1 (-2.90 KB ✅)
@alfalab/core-components-input-autocomplete/desktop/index.js 152.1 (-3.00 KB ✅)
@alfalab/core-components-input-autocomplete/mobile/index.js 223.8 (-2.90 KB ✅)
@alfalab/core-components-international-phone-input/index.js 548.4 (-3.00 KB ✅)
@alfalab/core-components-international-phone-input/desktop/index.js 466 (-2.90 KB ✅)
@alfalab/core-components-international-phone-input/mobile/index.js 520.5 (-2.90 KB ✅)
@alfalab/core-components-intl-phone-input/index.js 653.5 (-3.00 KB ✅)
@alfalab/core-components-picker-button/index.js 244.3 (-3.00 KB ✅)
@alfalab/core-components-picker-button/desktop/index.js 137.7 (-3.00 KB ✅)
@alfalab/core-components-picker-button/mobile/index.js 217.2 (-2.90 KB ✅)
@alfalab/core-components-scrollbar/index.js 62.6 (+25.20 KB ❌)
@alfalab/core-components-select/index.js 240.2 (-3.00 KB ✅)
@alfalab/core-components-select/desktop/index.js 156.1 (-3.00 KB ✅)
@alfalab/core-components-select/mobile/index.js 213.9 (-3.00 KB ✅)
@alfalab/core-components-select/shared/index.js 196.6 (-2.90 KB ✅)
@alfalab/core-components-select-with-tags/index.js 226.3 (-3.00 KB ✅)
@alfalab/core-components-select-with-tags/desktop/index.js 199.7 (-3.10 KB ✅)
@alfalab/core-components-select-with-tags/mobile/index.js 200.2 (-3.00 KB ✅)
@alfalab/core-components-table/index.js 168.1 (-3.00 KB ✅)
@alfalab/core-components-tabs/collapsible/index.js 147.1 (-3.00 KB ✅)

@coveralls

coveralls commented Jun 18, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 28172719700

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage decreased (-0.5%) to 81.789%

Details

  • Coverage decreased (-0.5%) from the base build.
  • Patch coverage: 8 uncovered changes across 3 files (54 of 62 lines covered, 87.1%).
  • 99 coverage regressions across 6 files.

Uncovered Changes

File Changed Covered %
packages/select/src/components/virtual-options-list/Component.tsx 16 11 68.75%
packages/select/src/utils.ts 16 14 87.5%
packages/shared/src/hooks/use-ref-as-state.ts 3 2 66.67%
Total (6 files) 62 54 87.1%

Coverage Regressions

99 previously-covered lines in 6 files lost coverage.

File Lines Losing Coverage Coverage
packages/calendar-range/src/hooks.ts 39 65.77%
packages/scrollbar/src/Component.tsx 20 63.89%
packages/scrollbar/src/simplebar/simplebar.js 17 46.17%
packages/universal-date-input/src/components/base-universal-date-input/Component.tsx 15 78.51%
packages/calendar-range/src/views/static.tsx 7 94.3%
packages/select/src/components/options-list/Component.tsx 1 91.3%

Coverage Stats

Coverage Status
Relevant Lines: 11749
Covered Lines: 9687
Line Coverage: 82.45%
Relevant Branches: 2226
Covered Branches: 1743
Branch Coverage: 78.3%
Branches in Coverage %: Yes
Coverage Strength: 235.99 hits per line

💛 - Coveralls

@github-actions

Copy link
Copy Markdown
Contributor

Demo build (default)

https://core-ds.github.io/core-components/2257

@github-actions

Copy link
Copy Markdown
Contributor

Demo build (alfasans)

https://core-ds.github.io/core-components/2257-alfasans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants