Skip to content

feat(icon-view, file-upload-item): Добавлена иконка заглушка при загрузке битого файла HELLOKITTY-1563#2238

Open
KaPuTaH-UluTka wants to merge 4 commits into
masterfrom
feat/HELLOKITTY-1563
Open

feat(icon-view, file-upload-item): Добавлена иконка заглушка при загрузке битого файла HELLOKITTY-1563#2238
KaPuTaH-UluTka wants to merge 4 commits into
masterfrom
feat/HELLOKITTY-1563

Conversation

@KaPuTaH-UluTka

@KaPuTaH-UluTka KaPuTaH-UluTka commented Jun 2, 2026

Copy link
Copy Markdown

Добавлена иконка заглушка при загрузке битой картинки

Чек лист

  • Задача сформулирована и описана в JIRA
  • В названии ветки есть айдишник задачи в JIRA (fix/DS-1234), ссылку прикреплять не надо
  • У реквеста осмысленное название feat(...) или fix(...) по conventional commits (https://www.conventionalcommits.org)
  • Код покрыт тестами и протестирован в различных браузерах
  • Добавленные пропсы добавлены в демки и описаны в документации
  • К реквесту добавлен changeset

Если есть визуальные изменения

  • Прикреплено изображение было/стало
image image

@changeset-bot

changeset-bot Bot commented Jun 2, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 63c0af2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@alfalab/core-components-icon-view Minor
@alfalab/core-components-file-upload-item Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Bundle size report

Entry point Size (minified)
@alfalab/core-components-file-upload-item/index.js 62 (+1.50 KB ❌)

@coveralls

coveralls commented Jun 2, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 26894754510

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage increased (+0.1%) to 82.306%

Details

  • Coverage increased (+0.1%) from the base build.
  • Patch coverage: 38 of 38 lines across 4 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 11713
Covered Lines: 9714
Line Coverage: 82.93%
Relevant Branches: 2218
Covered Branches: 1752
Branch Coverage: 78.99%
Branches in Coverage %: Yes
Coverage Strength: 232.47 hits per line

💛 - Coveralls

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Demo build (default)

https://core-ds.github.io/core-components/2238

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Demo build (alfasans)

https://core-ds.github.io/core-components/2238-alfasans

@KaPuTaH-UluTka KaPuTaH-UluTka marked this pull request as ready for review June 5, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants