Skip to content

feat/DS-15531_clear#2203

Open
fulcanellee wants to merge 2 commits into
masterfrom
feat/DS-15531_clear
Open

feat/DS-15531_clear#2203
fulcanellee wants to merge 2 commits into
masterfrom
feat/DS-15531_clear

Conversation

@fulcanellee

@fulcanellee fulcanellee commented May 6, 2026

Copy link
Copy Markdown
Contributor

DS-15531

Input

Раобота пропа clear разделена на 2 механики:

  • false или never — не отображается
  • true или always — отображается всегда
  • auto — отображается только при взаимодействии c input (hover, focus)
  • Исправлен размер контейнера иконки статусов (success, error)

Булевы значения будут удалены в core-components@51

@fulcanellee fulcanellee marked this pull request as draft May 6, 2026 07:39
@changeset-bot

changeset-bot Bot commented May 6, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bccdfeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages
Name Type
@alfalab/core-components Minor
@alfalab/core-components-input Minor
@alfalab/core-components-amount-input Patch
@alfalab/core-components-date-input Patch
@alfalab/core-components-date-range-input Patch
@alfalab/core-components-date-time-input Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-masked-input Patch
@alfalab/core-components-number-input Patch
@alfalab/core-components-password-input Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-select Patch
@alfalab/core-components-slider-input Patch
@alfalab/core-components-time-input Patch
@alfalab/core-components-universal-date-input Patch
@alfalab/core-components-with-suffix Patch
@alfalab/core-components-calendar-input Patch
@alfalab/core-components-calendar-range Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-bank-card Patch
@alfalab/core-components-phone-input Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls

coveralls commented May 6, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 26146264774

Coverage decreased (-0.004%) to 82.24%

Details

  • Coverage decreased (-0.004%) from the base build.
  • Patch coverage: 4 uncovered changes across 1 file (17 of 21 lines covered, 80.95%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
packages/input/src/components/base-input/Component.tsx 21 17 80.95%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 11629
Covered Lines: 9636
Line Coverage: 82.86%
Relevant Branches: 2211
Covered Branches: 1746
Branch Coverage: 78.97%
Branches in Coverage %: Yes
Coverage Strength: 235.87 hits per line

💛 - Coveralls

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Demo build (default)

https://core-ds.github.io/core-components/2203

@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Demo build (alfasans)

https://core-ds.github.io/core-components/2203-alfasans

@fulcanellee fulcanellee marked this pull request as ready for review May 6, 2026 08:48
@fulcanellee fulcanellee requested a review from Oladii May 6, 2026 08:48

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не уверен что в название пропа стоит зашивать Search
мб безопасней будет просто описать clear: always, onHover или типо того?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

статус прыгает, остальное ок)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

исправлено

Comment thread .changeset/sour-pants-drive.md Outdated

Раобота пропа `clear` разделена на 2 механики:
- `true` или `default` — стандартная механика, отображается только при взаимодействии
- `always` — поисковая механика, отображается всегда

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

51: 'always' | 'auto' | 'never'

50: (true | 'always') | (false | 'never') | 'auto'

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

поправил

@fulcanellee fulcanellee force-pushed the feat/DS-15531_clear branch 3 times, most recently from cb62fb5 to a3face5 Compare May 18, 2026 11:17
@fulcanellee fulcanellee force-pushed the feat/DS-15531_clear branch from a3face5 to 56ac8e2 Compare May 18, 2026 11:26
@fulcanellee fulcanellee requested a review from hextion May 18, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants