Skip to content

fix(base-modal): удалены deprecated props [DS-16452]#2201

Draft
dHIM24 wants to merge 2 commits into
masterfrom
DS-16452-major
Draft

fix(base-modal): удалены deprecated props [DS-16452]#2201
dHIM24 wants to merge 2 commits into
masterfrom
DS-16452-major

Conversation

@dHIM24

@dHIM24 dHIM24 commented May 5, 2026

Copy link
Copy Markdown
Contributor

Кратко сформулируйте суть доработки

Чек лист

  • Задача сформулирована и описана в JIRA
  • В названии ветки есть айдишник задачи в JIRA (fix/DS-1234), ссылку прикреплять не надо
  • У реквеста осмысленное название feat(...) или fix(...) по conventional commits (https://www.conventionalcommits.org)
  • Код покрыт тестами и протестирован в различных браузерах
  • Добавленные пропсы добавлены в демки и описаны в документации
  • К реквесту добавлен changeset

Если есть визуальные изменения

  • Прикреплено изображение было/стало

@changeset-bot

changeset-bot Bot commented May 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c6c341b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

Bundle size report

Entry point Size (minified)
@alfalab/core-components-bottom-sheet/index.js 87.3 (-1.90 KB ✅)
@alfalab/core-components-calendar/index.js 183.1 (-2.00 KB ✅)
@alfalab/core-components-calendar/mobile/index.js 182.9 (-2.00 KB ✅)
@alfalab/core-components-calendar-input/index.js 253.7 (-2.00 KB ✅)
@alfalab/core-components-calendar-input/mobile/index.js 253.4 (-2.10 KB ✅)
@alfalab/core-components-calendar-range/index.js 261.1 (-2.00 KB ✅)
@alfalab/core-components-custom-picker-button/index.js 247.7 (-1.90 KB ✅)
@alfalab/core-components-custom-picker-button/mobile/index.js 220.2 (-1.90 KB ✅)
@alfalab/core-components-date-range-input/index.js 253.1 (-2.10 KB ✅)
@alfalab/core-components-date-range-input/mobile/index.js 252.4 (-2.00 KB ✅)
@alfalab/core-components-date-time-input/index.js 252.6 (-2.00 KB ✅)
@alfalab/core-components-date-time-input/mobile/index.js 251.9 (-2.00 KB ✅)
@alfalab/core-components-drawer/index.js 54.6 (-1.90 KB ✅)
@alfalab/core-components-gallery/index.js 624.1 (-2.00 KB ✅)
@alfalab/core-components-input-autocomplete/index.js 252.2 (-1.90 KB ✅)
@alfalab/core-components-input-autocomplete/mobile/index.js 224.9 (-1.90 KB ✅)
@alfalab/core-components-international-phone-input/index.js 549.7 (-1.90 KB ✅)
@alfalab/core-components-international-phone-input/mobile/index.js 521.8 (-1.90 KB ✅)
@alfalab/core-components-modal/index.js 75.7 (-2.00 KB ✅)
@alfalab/core-components-modal/desktop/index.js 75.5 (-2.00 KB ✅)
@alfalab/core-components-modal/mobile/index.js 75.5 (-2.00 KB ✅)
@alfalab/core-components-modal/shared/index.js 53.4 (-2.00 KB ✅)
@alfalab/core-components-picker-button/index.js 245.6 (-1.90 KB ✅)
@alfalab/core-components-picker-button/mobile/index.js 218.5 (-1.80 KB ✅)
@alfalab/core-components-popup-sheet/index.js 69.7 (-2.00 KB ✅)
@alfalab/core-components-select/index.js 241.5 (-1.90 KB ✅)
@alfalab/core-components-select/mobile/index.js 215 (-1.90 KB ✅)
@alfalab/core-components-select/shared/index.js 198 (-2.00 KB ✅)
@alfalab/core-components-select-with-tags/index.js 227.2 (-1.90 KB ✅)
@alfalab/core-components-select-with-tags/desktop/index.js 200.5 (-2.00 KB ✅)
@alfalab/core-components-select-with-tags/mobile/index.js 201.1 (-1.90 KB ✅)
@alfalab/core-components-side-panel/index.js 78.5 (-2.00 KB ✅)
@alfalab/core-components-side-panel/desktop/index.js 76.6 (-2.00 KB ✅)
@alfalab/core-components-side-panel/mobile/index.js 74.9 (-2.00 KB ✅)
@alfalab/core-components-side-panel/shared/index.js 53.4 (-2.00 KB ✅)
@alfalab/core-components-tooltip/index.js 116.9 (-1.80 KB ✅)
@alfalab/core-components-tooltip/mobile/index.js 88.1 (-1.90 KB ✅)
@alfalab/core-components-universal-modal/index.js 116.1 (-2.00 KB ✅)
@alfalab/core-components-universal-modal/desktop/index.js 113.5 (-2.00 KB ✅)
@alfalab/core-components-universal-modal/mobile/index.js 74.5 (-2.00 KB ✅)
@alfalab/core-components-universal-modal/shared/index.js 53.4 (-2.00 KB ✅)

@dHIM24 dHIM24 force-pushed the DS-16452-major branch from 093f135 to f4dfda1 Compare May 5, 2026 08:02
@dHIM24 dHIM24 changed the title (fix/base-modal): удалены deprecated props [DS-16452] fix(base-modal): удалены deprecated props [DS-16452] May 5, 2026
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 25365054698

Coverage decreased (-0.3%) to 81.985%

Details

  • Coverage decreased (-0.3%) from the base build.
  • Patch coverage: 2 of 2 lines across 2 files are fully covered (100%).
  • 37 coverage regressions across 4 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

37 previously-covered lines in 4 files lost coverage.

File Lines Losing Coverage Coverage
packages/base-modal/src/utils.ts 32 19.3%
packages/global-store/src/GlobalStore.ts 2 50.0%
packages/global-store/src/ModalStore.ts 2 33.33%
packages/base-modal/src/helpers/lockScroll.ts 1 36.36%

Coverage Stats

Coverage Status
Relevant Lines: 11694
Covered Lines: 9667
Line Coverage: 82.67%
Relevant Branches: 2200
Covered Branches: 1724
Branch Coverage: 78.36%
Branches in Coverage %: Yes
Coverage Strength: 232.83 hits per line

💛 - Coveralls

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

Demo build (default)

https://core-ds.github.io/core-components/2201

@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

Demo build (alfasans)

https://core-ds.github.io/core-components/2201-alfasans

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants