Skip to content

fix(bottom-sheet): исправлен скачок magnetic-areas [DS-16410]#2197

Draft
dHIM24 wants to merge 1 commit into
masterfrom
DS-16410-bugfix
Draft

fix(bottom-sheet): исправлен скачок magnetic-areas [DS-16410]#2197
dHIM24 wants to merge 1 commit into
masterfrom
DS-16410-bugfix

Conversation

@dHIM24

@dHIM24 dHIM24 commented Apr 30, 2026

Copy link
Copy Markdown
Contributor
BottomSheet
  • Исправлено нестабильное поведение BottomSheet при динамической смене magneticAreas.
  • Если после обновления magneticAreas активный индекс выходит за границы массива (например, когда массив стал короче), компонент теперь переводит шторку в ближайшую доступную магнитную область вместо сброса в offset 0. Это устраняет рывки и визуальные скачки, сохраняя ближайшую предыдущую высоту.

Чек лист

  • Задача сформулирована и описана в JIRA
  • В названии ветки есть айдишник задачи в JIRA (fix/DS-1234), ссылку прикреплять не надо
  • У реквеста осмысленное название feat(...) или fix(...) по conventional commits (https://www.conventionalcommits.org)
  • Код покрыт тестами и протестирован в различных браузерах
  • Добавленные пропсы добавлены в демки и описаны в документации
  • К реквесту добавлен changeset

Если есть визуальные изменения

  • Прикреплено изображение было/стало

Было:

2026-04-10.13.10.13.mov

Стало:

2026-04-30.09.14.32.mov

@changeset-bot

changeset-bot Bot commented Apr 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5184d6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@alfalab/core-components-bottom-sheet Patch
@alfalab/core-components Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-select Patch
@alfalab/core-components-tooltip Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components-table Patch
@alfalab/core-components-gallery Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 25151163734

Coverage increased (+0.04%) to 82.303%

Details

  • Coverage increased (+0.04%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (15 of 16 lines covered, 93.75%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
packages/bottom-sheet/src/component.tsx 16 15 93.75%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 11743
Covered Lines: 9743
Line Coverage: 82.97%
Relevant Branches: 2220
Covered Branches: 1749
Branch Coverage: 78.78%
Branches in Coverage %: Yes
Coverage Strength: 232.3 hits per line

💛 - Coveralls

@github-actions

Copy link
Copy Markdown
Contributor

Demo build (default)

https://core-ds.github.io/core-components/2197

@github-actions

Copy link
Copy Markdown
Contributor

Demo build (alfasans)

https://core-ds.github.io/core-components/2197-alfasans

@dHIM24 dHIM24 marked this pull request as ready for review April 30, 2026 07:44
@github-actions

Copy link
Copy Markdown
Contributor

Snapshot release

Successfully released the following packages:

  1. @alfalab/core-components-bottom-sheet@8.1.5-5184d6fa2d33e9087998d84c0833a6182c7c0a29

  2. @alfalab/core-components-custom-picker-button@4.1.5-5184d6fa2d33e9087998d84c0833a6182c7c0a29

  3. @alfalab/core-components-gallery@7.1.5-5184d6fa2d33e9087998d84c0833a6182c7c0a29

  4. @alfalab/core-components-input-autocomplete@14.0.12-5184d6fa2d33e9087998d84c0833a6182c7c0a29

  5. @alfalab/core-components-international-phone-input@4.0.12-5184d6fa2d33e9087998d84c0833a6182c7c0a29

  6. @alfalab/core-components-intl-phone-input@11.0.12-5184d6fa2d33e9087998d84c0833a6182c7c0a29

  7. @alfalab/core-components-picker-button@13.0.12-5184d6fa2d33e9087998d84c0833a6182c7c0a29

  8. @alfalab/core-components@50.12.1-5184d6fa2d33e9087998d84c0833a6182c7c0a29

  9. @alfalab/core-components-select@19.1.5-5184d6fa2d33e9087998d84c0833a6182c7c0a29

  10. @alfalab/core-components-select-with-tags@10.1.5-5184d6fa2d33e9087998d84c0833a6182c7c0a29

  11. @alfalab/core-components-table@4.0.12-5184d6fa2d33e9087998d84c0833a6182c7c0a29

  12. @alfalab/core-components-tabs@10.0.12-5184d6fa2d33e9087998d84c0833a6182c7c0a29

  13. @alfalab/core-components-tooltip@9.0.10-5184d6fa2d33e9087998d84c0833a6182c7c0a29

@dHIM24 dHIM24 marked this pull request as draft May 18, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants