Skip to content

fix(release): fail publish workflow on registry errors #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
victormartingil wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(release): fail publish workflow on registry errors #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,16 @@ jobs:
run: pnpm build

- name: Publish to npm
continue-on-error: true
run: pnpm publish --access public --no-git-checks
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Verify npm publish
run: |
PACKAGE_VERSION="$(node -p "require('./package.json').version")"
PUBLISHED_VERSION="$(npm view "@corbat-tech/coco@${PACKAGE_VERSION}" version)"
test "$PUBLISHED_VERSION" = "$PACKAGE_VERSION"

# ── 2. VS Code Marketplace ───────────────────────────────────────────────────
release-vscode:
name: Publish VS Code Extension
Expand Down Expand Up @@ -78,7 +83,6 @@ jobs:
retention-days: 90

- name: Publish to VS Code Marketplace
continue-on-error: true
run: npm run publish
env:
VSCE_PAT: ${{ secrets.VSCE_PAT }}
Expand Down