Map localized S7 dock error states - #1361
Draft
copystring wants to merge 1 commit into
Draft
Conversation
2 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
The S7 Pro Ultra reports dock warnings through
get_status.dock_error_status. The AppPlugin treats that value as part of the same error namespace aserror_code, but the adapter exposed it only as an unmapped number.Changes
roborock_strings.jsoncommon.statesmapping toerror_codeanddock_error_status38User impact
For the reported warning,
dock_error_status = 38is now shown as the localized clean-water-tank warning instead of only the raw number. Existing ioBroker objects are updated when their states mapping differs.Validation
npm run test:unit— 272 tests passednpm run linttsc --noEmitFixes #1359