Skip to content

Map localized S7 dock error states - #1361

Draft
copystring wants to merge 1 commit into
mainfrom
fix/1359-dock-error-mapping
Draft

Map localized S7 dock error states#1361
copystring wants to merge 1 commit into
mainfrom
fix/1359-dock-error-mapping

Conversation

@copystring

Copy link
Copy Markdown
Owner

Root cause

The S7 Pro Ultra reports dock warnings through get_status.dock_error_status. The AppPlugin treats that value as part of the same error namespace as error_code, but the adapter exposed it only as an unmapped number.

Changes

  • extract the complete S7 MaxV AppPlugin error table into a reproducible JSON dataset
  • retain title, subtitle, description, detail, fallback, and translation keys for 107 error codes
  • resolve the mapping through the adapter's selected language and existing roborock_strings.json
  • apply the same localized common.states mapping to error_code and dock_error_status
  • add regression coverage for S7 Pro Ultra code 38

User impact

For the reported warning, dock_error_status = 38 is now shown as the localized clean-water-tank warning instead of only the raw number. Existing ioBroker objects are updated when their states mapping differs.

Validation

  • npm run test:unit — 272 tests passed
  • npm run lint
  • tsc --noEmit
  • regenerated JSON matched the committed output byte-for-byte

Fixes #1359

@stale

stale Bot commented Jul 30, 2026

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale Issues marked as stale label Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Issues marked as stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

S7 Pro Ultra dockingStationStatus nicht vorhanden

1 participant