Repository navigation
Fix HLS and DASH detection for media fragment URLs - #2053
Open
ArianMoeini wants to merge 1 commit into
Open
ArianMoeini wants to merge 1 commit into
ArianMoeini wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2046.
Media fragments after
.m3u8and.mpdcurrently prevent HLS/DASH detection, so those URLs fall through to the HTML video player. Audio URLs with fragments and fractional video start times have the same issue.This change treats
?and#as terminators after recognized audio, video, HLS, and DASH extensions. It retains the existing extension boundary checks and adds regression coverage for manifest routing, fractional and generic fragments, query strings, and near-miss extensions.Validation:
npm testsuite passes under Node 20 (the repository's CI runtime); two existing render tests remain skipped.npm run lintandnpm run typespass.I did not run browser playback against a live stream; the tests verify source selection.