Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ECSExecrack parameter (Yes/No, default No) to enable ECS Exec for interactive container shell access via SSM Session Managerconvox execuses ECS Exec when enabled (gen2 apps only), with automatic fallback to Docker exec for pre-enable tasks, gen1 apps, and disabled rackssession-manager-pluginlocally (same approach asaws ecs execute-command)Parameters
ECSExecChanges
formation/rack.jsonECSExecparameter + docker labels on 4 task definitionsformation/app.json.tmplECSExecparam/condition, conditional SSM perms on ServiceRole, passthrough to service stacksformation/service.json.tmplECSExecparam/condition,EnableExecuteCommandon ECS Service, conditional SSM perms on DedicatedRoleprovider/aws/aws.goECSExecbool field +loadParamslabel readprovider/aws/processes.goProcessExec,EnableExecuteCommandinProcessRun, Docker fallbackprovider/aws/releases.goECSExecrack param and pass to app stackssdk/sdk.gorunSessionManagerPluginfunction, session structsdk/methods.gopkg/cli/rack.goECSExectosecurityparam grouppkg/cli/rack_group_test.goprovider/aws/processes_test.goUpgrade notes
ECSExec=Yes, existing running tasks use Docker exec until redeployed (CloudTrail gap during transition)session-manager-pluginon their machine for ECS Exec sessionsssmmessagesandssmECSExec=NoCloudFormation impact
ECSExec(Default: No) added to rack, app, and service templatesECSExecEnabledin app and service templatesEnableExecuteCommandproperty added to ECS Service resource (conditional)ssm-execinline policy on ServiceRole (app.json.tmpl) and DedicatedRole (service.json.tmpl)