docs: use qualified using for CairoMakie (fix meta no-import test) - #551
Merged
Merged
Conversation
The SVG plotting setup merged in #550 used `import CairoMakie`, which trips the `test_no_import` regression guard (Handbook tenet 2: using, never import). Use `using CairoMakie: CairoMakie, Makie` instead: it loads CairoMakie, keeps Makie's `plot`/`plot!` out of Main (no clash with Plots in `@docs` blocks), and still enables the SVG backend / disables PNG output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SVG/PNG plotting setup merged in #550 used
import CairoMakie, which violates Handbook tenet 2 ("using, never import") and fails thetest_no_importregression guard (verified: 1 failure on main).Use
using CairoMakie: CairoMakie, Makieinstead — identical behaviour: loads CairoMakie, keeps Makie'splot/plot!out ofMain(no clash with Plots in@docsblocks), enables the SVG backend, and disables PNG output. Verified:test_no_importpasses and the full test suite passes.