Oprava zobrazení tlačítka reset filtru při vypnutých collapsible filtrech - #1307
Open
radimvaculik wants to merge 1 commit into
Open
Oprava zobrazení tlačítka reset filtru při vypnutých collapsible filtrech#1307radimvaculik wants to merge 1 commit into
radimvaculik wants to merge 1 commit into
Conversation
…rech Při setCollapsibleOuterFilters(false) se tlačítko pro reset filtru (a jeho snippet) vůbec nevykreslilo, protože bylo uvnitř řádku podmíněného collapsible filtry. Řádek se nyní vykresluje vždy a podmínka zůstává jen na samotném collapse tlačítku. Fixes #1306
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1307 +/- ##
=======================================
Coverage 49.12% 49.12%
=======================================
Files 63 63
Lines 2974 2974
=======================================
Hits 1461 1461
Misses 1513 1513 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
@radekdostal Could you test it, please? |
Contributor
|
@radimvaculik Yes, this change fixes the bug. Thanks! |
Member
Author
|
@f3l1x Could you merge it, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Souhrn
Při
setCollapsibleOuterFilters(false)v kombinaci s outer filter renderingem se tlačítko pro reset filtru nezobrazovalo nikde:n:if="$control->hasCollapsibleOuterFilters()", takže se při vypnutých collapsible filtrech vůbec nevykreslil (včetně{include reset-filter}),!$control->hasOuterFilterRendering().Regrese z refaktoringu 00f2142 (7.2.0) — dříve se tlačítko v patičce vykreslovalo bez podmínky. Vedlejší důsledek: nevykresloval se ani snippet
reset-filter, takže nefungovalo jeho AJAXové překreslení.Oprava
Řádek
datagrid-collapse-filters-button-rowse vykresluje vždy,n:ifshasCollapsibleOuterFilters()zůstává jen na samotném collapse tlačítku „Zobrazit filtr". Reset tlačítko i jeho snippet jsou tak přítomné i u nesbalitelných outer filtrů.Fixes #1306