Header search improvements - #19
Merged
Merged
Conversation
a-effort
marked this pull request as ready for review
August 13, 2026 04:59
Signed-off-by: Anna Effort <anna.effort@ibm.com>
Signed-off-by: Anna Effort <anna.effort@ibm.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Anna Effort <anna.effort@ibm.com>
a-effort
force-pushed
the
search-adjustments
branch
from
August 13, 2026 05:22
aa6d361 to
b5b6f73
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Style, interaction, and accessibility update to the header search. Also fixes a responsive bug that hid the search entirely on smaller screens.
Changes
w-0.Commandglyph rather than a text character; Windows/Linux still get a textCtrl.getQuickNavShortcutLabelbecameisAppleShortcutPlatformand returns a boolean instead of a prebuilt string.md, 400px atlg(md:w-75 lg:w-100)w-75 lg:w-100, up from a fixedw-80.::-webkit-search-cancel-button(system-accent blue, unthemeable) is suppressed viaappearance-none, replaced by a lucideXbutton that clears the query and returns focus.Loadingspinner and now renders identically to the other status messages.aria-expandedderive from a singleisResultsOpenthat requires a query.role="status"live region now stays mounted for the component's lifetime and mirrors dropdown state, including a new result-count announcement. Previously results arrived silently after "Searching…".hidden md:blockwhile the sidebar collapses at 768px, so it disappeared exactly when the nav collapsed. Now visible at all widths, with the shortcut chip hidden belowmdand a50vwcap on the expanded field.sm, matching the version label, to give the search room on narrow viewports.common.search.clearandcommon.search.resultCountto en-US, es-ES, and pt-BR.search.mp4
Test plan
md/lgnpm run build,tsc --noEmit, and the layout suite (55 tests) passKnown follow-ups
scrollIntoViewfor thearia-activedescendanthighlight.ListSearch(catalog, Teams, Servers, Users) still shows the native blue "clear" button: same one-line fix, best applied once inListSearchorInput.color-scheme, so native chrome (scrollbars, autofill) still renders light-scheme in dark mode.