ci: enforce detect-secrets baseline - #85
Merged
Merged
Conversation
Signed-off-by: lucarlig <luca.carlig@ibm.com>
Signed-off-by: lucarlig <luca.carlig@ibm.com>
gandhipratik203
approved these changes
Aug 11, 2026
gandhipratik203
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Sync with the PR #80 for the merge order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
detect-secretsjob to the existing CI workflowscripts/ci/detect-secrets.shdetect-secrets-hookagainst all tracked files with the audited-baseline gate enabled.secrets.baselineis added tomainWhy
The existing Rust CI jobs can all pass without exercising detect-secrets. PR #80 demonstrated this: the committed baseline was stale, but the standard CI rollup remained green.
After this PR lands, PR #80 can be rebased onto
main; the new job will then detect its baseline drift and enforce detect-secrets on every pull request and push tomain.Impact
The job reports a notice and passes until
.secrets.baselineexists. Once the baseline is present, new findings, unaudited entries, and baseline rewrites fail CI.Validation
actionlint .github/workflows/ci.ymlbash -n scripts/ci/detect-secrets.shshellcheck scripts/ci/detect-secrets.shgit diff --checkmainselects bootstrap mode