Skip to content

ci: enforce detect-secrets baseline - #85

Merged
lucarlig merged 2 commits into
mainfrom
user/luca/ci-detect-secrets
Aug 11, 2026
Merged

ci: enforce detect-secrets baseline#85
lucarlig merged 2 commits into
mainfrom
user/luca/ci-detect-secrets

Conversation

@lucarlig

@lucarlig lucarlig commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a dedicated detect-secrets job to the existing CI workflow
  • keep workflow YAML minimal by delegating to scripts/ci/detect-secrets.sh
  • install only the pinned IBM detect-secrets fork in a runner-local virtualenv
  • run detect-secrets-hook against all tracked files with the audited-baseline gate enabled
  • allow the job to bootstrap cleanly before .secrets.baseline is added to main

Why

The existing Rust CI jobs can all pass without exercising detect-secrets. PR #80 demonstrated this: the committed baseline was stale, but the standard CI rollup remained green.

After this PR lands, PR #80 can be rebased onto main; the new job will then detect its baseline drift and enforce detect-secrets on every pull request and push to main.

Impact

The job reports a notice and passes until .secrets.baseline exists. Once the baseline is present, new findings, unaudited entries, and baseline rewrites fail CI.

Validation

  • actionlint .github/workflows/ci.yml
  • bash -n scripts/ci/detect-secrets.sh
  • shellcheck scripts/ci/detect-secrets.sh
  • git diff --check
  • verified current main selects bootstrap mode
  • verified PR chore: adopt make pre-commit workflow with full pre-commit hook suite #80 activates the direct hook and exposes its stale baseline
  • verified the same hook passes after the corrected baseline is staged
  • repository commit gate passed: fmt, clippy, cargo-deny, nextest, build, and bench

Signed-off-by: lucarlig <luca.carlig@ibm.com>
Signed-off-by: lucarlig <luca.carlig@ibm.com>
@lucarlig
lucarlig requested a review from Lang-Akshay August 11, 2026 12:06
@lucarlig
lucarlig marked this pull request as ready for review August 11, 2026 12:07
@lucarlig lucarlig self-assigned this Aug 11, 2026

@gandhipratik203 gandhipratik203 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sync with the PR #80 for the merge order.

@lucarlig
lucarlig merged commit e50fc5e into main Aug 11, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants