Skip to content

fix(website): keep Page Up and Page Down working in metadata margins #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lucki2g merged 3 commits into from
Oct 5, 2026
Merged

fix(website): keep Page Up and Page Down working in metadata margins #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30fb3d3
fix(website): preserve keyboard scrolling in metadata margins
Bircck Sep 11, 2026
c9e7055
chore: rebase to main
Lucki2g Oct 2, 2026
265d726
chore(release): release 2.3.9
github-actions[bot] Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .release-please-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"Website": "2.3.8"
"Website": "2.3.9"
}
11 changes: 11 additions & 0 deletions Website/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
## [2.3.9] - 2026-10-05

### Bug Fixes

* fix(website): preserve keyboard scrolling in metadata margins ([30fb3d3](https://github.com/context-and-oss/DataModelViewer/commit/30fb3d3))

### Other Changes

* rebase to main ([c9e7055](https://github.com/context-and-oss/DataModelViewer/commit/c9e7055))


## [2.3.8] - 2026-10-02

### Features
Expand Down
2 changes: 1 addition & 1 deletion Website/app/metadata/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default function Data() {
<Suspense>
<DatamodelViewProvider>
<EntityFiltersProvider>
<Layout>
<Layout ignoreMargins>
<DatamodelView />
</Layout>
</EntityFiltersProvider>
Expand Down
129 changes: 69 additions & 60 deletions Website/components/datamodelview/List.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { updateURL } from "@/lib/url-utils";
import { copyToClipboard, generateGroupLink } from "@/lib/clipboard-utils";
import { useSnackbar } from "@/contexts/SnackbarContext";
import { useEntityFilters } from "@/contexts/EntityFiltersContext";
import { Box, CircularProgress, debounce, Tooltip } from '@mui/material';
import { Box, CircularProgress, Container, debounce, Tooltip } from '@mui/material';

interface IListProps {
setCurrentIndex: (index: number) => void;
Expand Down Expand Up @@ -287,7 +287,15 @@ export const List = ({ setCurrentIndex, entityActiveTabs }: IListProps) => {
<Box className={`absolute w-full h-full flex items-center justify-center z-[100] transition-opacity duration-300 ${loadingSection ? 'opacity-100' : 'opacity-0 pointer-events-none'}`}>
<CircularProgress />
</Box>
<div ref={parentRef} style={{ height: 'calc(100vh - var(--layout-header-desktop-height))', overflow: 'auto' }} className="relative no-scrollbar">
<div
ref={parentRef}
tabIndex={0}
role="region"
aria-label="Metadata tables"
style={{ height: 'calc(100vh - var(--layout-header-desktop-height))', overflow: 'auto' }}
className="relative no-scrollbar"
>
<Container maxWidth="xl">

{/* Show no results message when searching but no items found */}
{flatItems.length === 0 && search && search.length >= 3 && (
Expand All @@ -299,64 +307,65 @@ export const List = ({ setCurrentIndex, entityActiveTabs }: IListProps) => {
</div>
)}

{/* Virtualized list */}
<div
className={`mx-6 my-6 transition-opacity duration-300 ${loadingSection ? 'opacity-0 pointer-events-none' : 'opacity-100'}`}
style={{
height: `${rowVirtualizer.getTotalSize()}px`,
width: 'calc(100% - 48px)',
position: 'relative',
visibility: flatItems.length === 0 ? 'hidden' : 'visible'
}}
>
{rowVirtualizer.getVirtualItems().map((virtualItem) => {
const item = flatItems[virtualItem.index];

return (
<div
key={virtualItem.key}
data-index={virtualItem.index}
style={{
position: 'absolute',
top: 0,
left: 0,
width: '100%',
transform: `translateY(${virtualItem.start}px)`,
}}
ref={(el) => {
if (el) {
rowVirtualizer.measureElement(el);
}
}}
>
{item.type === 'group' ? (
<div className="flex items-center py-6 my-4">
<div className="flex-1 h-0.5 bg-gray-200" />
<Tooltip title="Copy link to this group">
<div
className="px-4 text-md font-semibold text-gray-700 uppercase tracking-wide whitespace-nowrap cursor-pointer hover:text-blue-600 transition-colors"
onClick={() => handleCopyGroupLink(item.group.Name)}
>
{item.group.Name}
</div>
</Tooltip>
<div className="flex-1 h-0.5 bg-gray-200" />
</div>
) : (
<div className="text-sm">
<Section
entity={item.entity}
group={item.group}
search={search}
activeTab={entityActiveTabs.get(item.entity.SchemaName)}
highlightSecurityRole={selectedSecurityRoles.length > 0 && hasSecurityRoleAccess(item.entity)}
/>
</div>
)}
</div>
);
})}
</div>
{/* Virtualized list */}
<div
className={`mx-6 my-6 transition-opacity duration-300 ${loadingSection ? 'opacity-0 pointer-events-none' : 'opacity-100'}`}
style={{
height: `${rowVirtualizer.getTotalSize()}px`,
width: 'calc(100% - 48px)',
position: 'relative',
visibility: flatItems.length === 0 ? 'hidden' : 'visible'
}}
>
{rowVirtualizer.getVirtualItems().map((virtualItem) => {
const item = flatItems[virtualItem.index];

return (
<div
key={virtualItem.key}
data-index={virtualItem.index}
style={{
position: 'absolute',
top: 0,
left: 0,
width: '100%',
transform: `translateY(${virtualItem.start}px)`,
}}
ref={(el) => {
if (el) {
rowVirtualizer.measureElement(el);
}
}}
>
{item.type === 'group' ? (
<div className="flex items-center py-6 my-4">
<div className="flex-1 h-0.5 bg-gray-200" />
<Tooltip title="Copy link to this group">
<div
className="px-4 text-md font-semibold text-gray-700 uppercase tracking-wide whitespace-nowrap cursor-pointer hover:text-blue-600 transition-colors"
onClick={() => handleCopyGroupLink(item.group.Name)}
>
{item.group.Name}
</div>
</Tooltip>
<div className="flex-1 h-0.5 bg-gray-200" />
</div>
) : (
<div className="text-sm">
<Section
entity={item.entity}
group={item.group}
search={search}
activeTab={entityActiveTabs.get(item.entity.SchemaName)}
highlightSecurityRole={selectedSecurityRoles.length > 0 && hasSecurityRoleAccess(item.entity)}
/>
</div>
)}
</div>
);
})}
</div>
</Container>
</div>
</>
);
Expand Down
4 changes: 2 additions & 2 deletions Website/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "website",
"version": "2.3.8",
"version": "2.3.9",
"private": true,
"scripts": {
"dev": "next dev",
Expand Down
Loading