feat: export Design Tokens as part of ExO entity group [AIS-120] - #2350
Open
Michael Pham (michaelphamcf) wants to merge 2 commits into
Open
feat: export Design Tokens as part of ExO entity group [AIS-120]#2350Michael Pham (michaelphamcf) wants to merge 2 commits into
Michael Pham (michaelphamcf) wants to merge 2 commits into
Conversation
Wires up the designToken plain client (added in AIS-352) into the existing "Fetching Design Tokens data" task, which was previously blocked and gracefully degrading to [] pending SDK support. Adds unit test coverage for the task (skip when flag unset, cursor-paginated fetch when set, graceful [] degrade on failure) - the first test coverage for any ExO entity task in this file. contentful-management dependency temporarily points at a local tarball built from contentful-management.js#feat/ais-352-design-token, since that branch is not yet merged/published to npm. Needs to be swapped for a real pre-release before merge. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…en support [AIS-120] contentful-management.js 12.12.0 now ships DesignToken support natively, so the local tarball placeholder is no longer needed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AIS-120
Summary
designTokenplain client (added in AIS-352) into the existing "Fetching Design Tokens data" task inget-space-data.js, which was previously blocked and gracefully degrading to[]pending SDK support. Removes the now-stale blocker comment.includeExperienceOrchestrationunset, cursor-paginated fetch when set, graceful[]degrade on failure) — the first test coverage for any ExO entity task in this file (componentTypes/templates/dataAssemblies/fragments/experiences still have none).contentful-managementto^12.12.0, which now ships DesignToken support natively — matches the pattern already used for the other 5 ExO entities.3fyh0othob6d,exoenvironment): all 16 seeded design tokens exported correctly alongside the other ExO entities (29 componentTypes, 1 template, 9 dataAssemblies).Test plan
npm run test:unit)Generated with Claude Code