mempolicy: treat empty nodes as unset - #2184
Merged
Merged
Conversation
An empty "nodes" string is parsed as a non-NULL empty string, so cpuset_string_to_bitmask() returns a NULL bitmask of size 0, and the subsequent memcpy(dst, NULL, 0) violates memcpy's nonnull constraint. Guard with is_empty_string(), the same way libcrun_set_cpu_affinity_from_string() does. Fixes: containers#2181 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An empty
nodesstring is parsed as a non-NULL empty string, socpuset_string_to_bitmask()returns a NULL bitmask of size 0, and the subsequentmemcpy(dst, NULL, 0)violates memcpy's nonnull constraint.Guard with
is_empty_string(), the same waylibcrun_set_cpu_affinity_from_string()does.Fixes #2181
🤖 Generated with Claude Code