linux: run createContainer hooks after mounts are set up - #2168
Merged
Conversation
PR containers#2094 moved libcrun_set_mounts after pivot_root but left the createContainer hooks before both, so they ran before /proc and other mounts existed, violating the OCI spec and breaking the NVIDIA Container Toolkit. Add create_container_len to can_use_open_tree_namespace() so the deferred-pivot path is used, and move the hooks to run after libcrun_set_mounts and before the pivot in libcrun_finalize_mounts. Fixes: containers#2167 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Member
Author
|
@jnovy PTAL |
Contributor
|
LGTM |
Member
Author
|
@henry118 could you verify if it solves your issue? |
|
@giuseppe this patch worked! thanks for the quick fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2094 moved libcrun_set_mounts after pivot_root but left the createContainer hooks before both, so they ran before /proc and other mounts existed, violating the OCI spec and breaking the NVIDIA Container Toolkit.
Add create_container_len to can_use_open_tree_namespace() so the deferred-pivot path is used, and move the hooks to run after libcrun_set_mounts and before the pivot in libcrun_finalize_mounts.
Fixes: #2167