shim/manager: detect early shim exit while waiting for pipe on Windows#198
Open
dmcgowan wants to merge 1 commit into
Open
shim/manager: detect early shim exit while waiting for pipe on Windows#198dmcgowan wants to merge 1 commit into
dmcgowan wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves Windows shim startup behavior by detecting when the shim process exits while containerd is still polling for the shim’s named pipe, avoiding pointless retries until timeout.
Changes:
- Capture
cmd.Wait()result in a buffered channel during shim startup. - While polling for the named pipe, return immediately if the shim has already exited.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Derek McGowan <derek@mcg.dev>
dmcgowan
force-pushed
the
windows-detect-early-exit
branch
from
211a91d to
f631c85
Compare
Kern--
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid retrying pipe connection when we get an early exit