Repository navigation
fix(deps): bump libpg-query to 18.2.0 - #362
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. 🟡 1 medium 📍 Findings outside the diff (1) — 🟡 1 medium — defects on lines GitHub can't attach comments to🟡 Medium — Bump // config/versions.json
3 "13": {
4 "libpg-query": "13.8.0",
5 "pgsql-parser": "13.19.1",
6 "pgsql-deparser": "13.19.1",
7 "@pgsql/types": "13.11.1",
8 "npmTag": "pg13"
9 },
10 "14": {
11 "libpg-query": "14.5.0",
12 "pgsql-parser": "14.1.1",
13 "pgsql-deparser": "14.1.1",
14 "@pgsql/types": "14.1.1",The diff bumps The change updates the PostgreSQL version matrix in
Reviewed commit: 46ae9bd |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Summary
Moves the 18 line onto the new
libpg-query@18.2.0. It fixes input being silently cut off at non-BMP characters or an embedded NUL, and lets the WASM module recover after an exception escapes a call. The build is now pinned to an exact C commit and emsdk 6.0.3, and the release recordsx-publish.wasmSha256. Before this PR, every package here pinslibpg-queryto exactly18.1.5, so their users can't get the fixes.libpg-querygoes from18.1.5to18.2.0in the 9 packages that pin it:parser,plpgsql-parser,parse,plpgsql-parse,plpgsql-deparser,lint, and the devDeps ofdeparser,pgsql-typesandtransform-ast. No API changes.pnpm-lock.yaml: only thelibpg-queryspecifier, version and integrity lines change, so the existing formatting is kept.pnpm install --frozen-lockfilepasses.config/versions.jsonand the pg13–17 tagged packages are intentionally unchanged, so they are not republished. Users who want the fixes upgrade to 18.Testing
pnpm buildpasses, and so doespnpm -r --no-bail test, except for 3 failures that also fail onmainwith 18.1.5:@pgsql/cliandpgsql-typeshave no tests (jest reports "No tests found").plpgsql-parseround-trip snapshot (status = v_status,total) fails; I checked outmainand confirmed it fails there too.Link to Devin session: https://app.devin.ai/sessions/bcd8b2f791164247acb7a659b481efc2
Open in Devin Desktop: https://app.devin.ai/desktop/session/bcd8b2f791164247acb7a659b481efc2?variant=devin
Requested by: @pyramation