Skip to content

docs(graphile-presigned-url-plugin): describe the live-row rule in place - #1979

Merged
devin-ai-integration[bot] merged 1 commit into
mainfrom
fix/public-wording-file-lifecycle
Nov 9, 2026
Merged

devin-ai-integration[bot] merged 1 commit into
mainfrom
fix/public-wording-file-lifecycle

Conversation

@pyramation

Copy link
Copy Markdown
Contributor

Summary

Comment-only change. The isLiveFileRow doc comment in graphile/graphile-presigned-url-plugin/src/file-lifecycle.ts now states the rule directly (a row is live, and a dedup hit or downloadUrl target, only once the bytes it names are in S3) instead of pointing at an external invariant label.

Checked the files touched by #1970, #1971, #1977 and #1978 on main for other new references of the same kind; this was the only one (the remaining matches in those files predate those PRs).

No code changes.

Link to Devin session: https://app.devin.ai/sessions/2c8a6e5b1ad0423f8bb10849a019c44b
Open in Devin Desktop: https://app.devin.ai/desktop/session/2c8a6e5b1ad0423f8bb10849a019c44b?variant=devin
Requested by: @pyramation

@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@luxor-code-review

luxor-code-review Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Review complete. No issues found — approved ✅.


This PR makes a comment-only edit to the presigned-URL plugin's file-lifecycle module: it removes a stale "invariant S2" reference from the documentation on the live-row predicate so the docs match the actual gating logic.

Files Change
graphile/graphile-presigned-url-plugin/src/file-lifecycle.ts Rewords a doc comment to remove the obsolete "invariant S2" wording; no executable change.

Reviewed commit: 0270d6e

@devin-ai-integration
devin-ai-integration Bot merged commit b4f4852 into main Nov 9, 2026
20 checks passed
@devin-ai-integration
devin-ai-integration Bot deleted the fix/public-wording-file-lifecycle branch November 9, 2026 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant