Repository navigation
docs(graphile-presigned-url-plugin): describe the live-row rule in place - #1979
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No issues found — approved ✅. This PR makes a comment-only edit to the presigned-URL plugin's file-lifecycle module: it removes a stale "invariant S2" reference from the documentation on the live-row predicate so the docs match the actual gating logic.
Reviewed commit: 0270d6e |
devin-ai-integration
Bot
deleted the
fix/public-wording-file-lifecycle
branch
November 9, 2026 04:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comment-only change. The
isLiveFileRowdoc comment ingraphile/graphile-presigned-url-plugin/src/file-lifecycle.tsnow states the rule directly (a row is live, and a dedup hit ordownloadUrltarget, only once the bytes it names are in S3) instead of pointing at an external invariant label.Checked the files touched by #1970, #1971, #1977 and #1978 on
mainfor other new references of the same kind; this was the only one (the remaining matches in those files predate those PRs).No code changes.
Link to Devin session: https://app.devin.ai/sessions/2c8a6e5b1ad0423f8bb10849a019c44b
Open in Devin Desktop: https://app.devin.ai/desktop/session/2c8a6e5b1ad0423f8bb10849a019c44b?variant=devin
Requested by: @pyramation