fix: queue enhancements under the resolved project namespace#162
Merged
Conversation
The enhancement queue was enqueuing every entry with the default project, while storage is project-aware. The worker then looked up entries in knowledge_default, found nothing, and recorded a failure — every enhancement since project namespacing rolled out has failed (8,560 failures, last success 2026-03-09). One-line fix: pass resolveProject() at the enqueue call site, matching the upsert above.
![lexi-chief-of-staff[bot]](https://avatars.githubusercontent.com/in/3490641?s=60&v=4){kind=small}
There was a problem hiding this comment.
Ship it.
- One-line project pass-through matches the exact mismatch described in the PR body.
- New test asserts the queue receives the resolved namespace, closing the regression path.
- Full test suite green and no new static-analysis issues.
- No other call sites or storage paths touched, so risk is contained.
There was a problem hiding this comment.
Ship it.
- One-line fix passes resolved project through to EnhancementQueueService::queue, matching the Qdrant upsert path five lines above.
- Regression test asserts the second argument and covers the 'mesh-status' case that has been failing since March.
- Existing KnowledgeAddCommandTest updated to expect the explicit 'default' project; no behavior change there.
- PHPStan and test suite both clean.
Contributor
Author
Quality Gate: errorThe repository "conduit-ui/knowledge" appears to be free from any significant code quality issues based on the provided tool violations. After reviewing the tool violations for the repository "conduit-ui/knowledge," it is evident that there are no critical issues reported by pint, pest, phpstan, or rector. This indicates that the codebase adheres to its coding standards and is free from major quality concerns. However, it's always a good practice to regularly run these tools to ensure ongoing compliance with best practices and potential improvements in code quality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enhancement queue enqueued entries without a project, defaulting to
default, while storage five lines up is project-aware.enhance:workerthen calledgetById(id, 'default'), found nothing inknowledge_default, and recorded a failure.Impact: every enhancement since project namespacing took over has failed — queue status shows 8,560 failures against 3,512 processed, last success 2026-03-09. Entries created since then never received Ollama tags/summary/concepts.
Fix is the one-line project pass-through at the enqueue call site, plus a regression test asserting the queue receives the resolved project.
Verified: full KnowledgeAddCommandTest suite green (25 tests); PHPStan errors unchanged from master (52 pre-existing, none in touched files).