fix: skip duplicate detection when upserting daily digest#158
Merged
Conversation
Digests are intentionally similar day-over-day, so the default similarity check throws DuplicateEntryException on consecutive active days and fails the nightly synthesis run. The existence check by title/date above already prevents true duplicates.
📊 Coverage Report
Files Below Threshold
🏆 Synapse Sentinel Gate |
🔧 Synapse Sentinel: 1 check need attentionThe following issues must be resolved before this PR can be merged: Security AuditReview the output and fix any issues.Quick Reference:
🤖 Generated by Synapse Sentinel - View Run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #156, found by running the fixed synthesis in production on odin: the digest upsert ran with duplicate detection enabled, and since consecutive days of similar activity produce similar digest content,
DuplicateEntryExceptionfails the whole nightly run (observed live: 07-02 digest at 96%+ similarity with 07-03 digest → exit 1).The title/date existence check earlier in
runDigestalready guards true duplicates — same-day reruns skip cleanly. Day-over-day similarity is expected behavior for digests, socheckDuplicates: falseon this one upsert.Tests pin the new argument; 15/15 passing.