New concepts#1522
Conversation
|
@AnnikaTjuka, could you moderate this PR? |
|
Sure. @alzkuc and @FredericBlum I think you were involved in some of the new concept proposals. Could you take a look at the PR? |
Sure, no problem! |
FredericBlum
left a comment
FredericBlum
left a comment
There was a problem hiding this comment.
I have three comments on the proposed concepts which could be worth discussing. But perhaps I am missing previous discussions on those questions?
alzkuc
left a comment
alzkuc
left a comment
There was a problem hiding this comment.
A few comments including the discussed FOOTBALL
| Liu-2011-435-149 149 苍蝇 fly 1504 FLY (INSECT) 1 2 2.81 3.69 4.03 3.32 2.83 0.63 1.86 0.70 2.44 10.45 0.06 1127 | ||
| Liu-2011-435-150 150 脚 foot 1301 FOOT 1 1 3.12 4.20 5.00 2.19 4.32 0.68 1.56 1.00 1.29 2.25 0.00 791 | ||
| Liu-2011-435-151 151 橄榄球 football 1 3 2.10 4.00 3.11 2.41 1.97 0.45 0.72 0.50 5.75 10.50 0.31 1374 | ||
| Liu-2011-435-151 151 橄榄球 football 4166 FOOTBALL 1 3 2.10 4.00 3.11 2.41 1.97 0.45 0.72 0.50 5.75 10.50 0.31 1374 |
There was a problem hiding this comment.
This is, for example, the ball, not the sport. And it refers to the European one.
| Nishimoto-2005-359-338 338 Yacht 4165 YACHT ヨット YOTTO 97.5 4.3 3.8 3 | ||
| Nishimoto-2005-359-339 339 Lion 1386 LION ライオン RAION 100.0 3.1 3.2 4 | ||
| Nishimoto-2005-359-340 340 Camel 1871 CAMEL ラクダ RAKUDA 97.5 4.1 2.9 3 | ||
| Nishimoto-2005-359-341 341 Football 1845 BALL ラグビーボール RAGUBÎ BÔRU 90.0 6.7 3.3 7 |
There was a problem hiding this comment.
This is the ball as well, but here it is the rugby one/american football one. (There is a difference, but the dataset lists it as football)
| Snodgrass-1980-260-93 93 1504 FLY (INSECT) Fly | ||
| Snodgrass-1980-260-94 94 1301 FOOT Foot | ||
| Snodgrass-1980-260-95 95 Football | ||
| Snodgrass-1980-260-95 95 4166 FOOTBALL Football |
There was a problem hiding this comment.
This is the American football ball.
| Dunabeitia-2022-500-275 275 407 mountain 639 MOUNTAIN | ||
| Dunabeitia-2022-500-276 276 408 finger 1303 FINGER | ||
| Dunabeitia-2022-500-277 277 409 cork | ||
| Dunabeitia-2022-500-277 277 409 cork 4158 CORK |
There was a problem hiding this comment.
the new concept CORK relates to agriculture and vegetation. This right here, however, refers to the actual cork in a bottle. I think this should either be part of the description, or disambiguated, if we are to map it as such.
There was a problem hiding this comment.
I'll refine the description to capture the substance and object meaning. Thank you for pointing this out!
|
I've added the FOOTBALL split and implemented the other changes. The Eurpoean vs. American football debate has been relocated to issue #1525 for the time being. For BASKETBALL, I decided to use the (BALL) concept for object naming studies since that made the most sense to me. |
Sure, I'll take a look! |
| 4164 TUNA Animals A large marine fish of the genus Thunnus, known for its streamlined body and importance as a commercial food species. Person/Thing | ||
| 4165 YACHT Modern world A recreational boat or vessel, typically medium to large in size, used for leisure cruising or racing on water. Person/Thing | ||
| 4166 FOOTBALL (GAME OR OBJECT) Modern world A sport played by two teams in which players move a ball toward a goal to score points, mainly by kicking or carrying it OR the ball used in that sport. Person/Thing | ||
| 4167 FOOTBALL (GAME) Modern world A sport played by two teams in which players move a ball toward a goal to score points, mainly by kicking or carrying it depending on the variant. Person/Thing |
There was a problem hiding this comment.
toward the goal post perhaps?
There was a problem hiding this comment.
So, I have taken a look and it seems good to go! Just left one small comment :-) Also, it would be great if you could also include the new concepts in concepticondata/conceptrelations.tsv. E.g. FOOTBALL (OBJECT) as an instance of BALL
There was a problem hiding this comment.
I've avoided adding to the conceptrelations file lately since the directionality of instanceof or narrower/wider is not 100% clear to me. I think ideally this would be handled by somebody who undertands the setup of that file better than I do.
As for the goal post comment, I can do that, it's a good idea. I'll also map any occurences of soccer to 4167 as well.
|
@AnnikaTjuka, would you have a final look at everything? |
AnnikaTjuka
left a comment
AnnikaTjuka
left a comment
There was a problem hiding this comment.
Looks good. Thanks, everyone!
5 participants
Pull request checklist
concepticon notlinked --gloss "NEW_GLOSS"Additional information
Adding 18 new concepts:
Further, the data format of some entries in Janschewitz-2008-460 was refined since it was faulty.
Regarding concept 4161 HOSE: Hill-2015-999-1280 also mapped because in Vulic-2020-2244-1507 we get HOSE for car and garden. Because this means that the term is already quite ambiguous, I decided to map it both times in Hill as well.
Regarding concept 4163 SLIPPER: I did not map Schroeder-2012-824-326 because the term might refer to an outside shoe and that's not what we usually consider a slipper.
Regarding 4166 FOOTBALL: I mapped both Schroeder-1012-824-573 and Schroeder-1012-824-574 because the description of this new concept does not differentiate American vs. European Football.