feat: allow to skip unsupported files#343
Open
yet-another-aligator wants to merge 1 commit into
Open
Conversation
yet-another-aligator
force-pushed
the
skip_unsupported_special
branch
2 times, most recently
from
November 2, 2023 17:38
2bcd07e to
fa458aa
Compare
yet-another-aligator
marked this pull request as draft
November 20, 2023 14:59
yet-another-aligator
force-pushed
the
skip_unsupported_special
branch
from
November 20, 2023 15:09
fa458aa to
83614b7
Compare
yet-another-aligator
force-pushed
the
skip_unsupported_special
branch
from
November 20, 2023 15:11
83614b7 to
1276766
Compare
yet-another-aligator
marked this pull request as ready for review
November 20, 2023 15:14
cgwalters
reviewed
Jun 3, 2024
cgwalters
left a comment
cgwalters
left a comment
Collaborator
There was a problem hiding this comment.
I think we really just need this as a variant of append_dir_all() right? I'd probably have it take a closure which filters the entries.
This was referenced Jun 4, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a new
Builder::skip_unsupported_file_types(&mut self, skip: bool)method, for allowing to silently skip unsupported files, instead of returning with an error.For the moment, this feature applies to the case of UNIX named sockets only.