Some changes#359
Merged
Merged
Conversation
Add features "error-context" and "suggestions" to show suggestions on incorrect command usage Before ```sh ./target/release/cfsctl --repo sysroot dump-files error: one or more required arguments were not provided ``` After ```sh ./target/release/cfsctl --repo sysroot dump-files error: the following required arguments were not provided: <IMAGE_NAME> Usage: cfsctl dump-files <IMAGE_NAME> [FILES]... For more information, try '--help'. ``` Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Johan-Liebert1
force-pushed
the
some-changes
branch
from
July 15, 2026 06:11
4d49a7d to
5c2bdaa
Compare
Useful in bootc to get backing path. Also update the signature to take in a repository and an image name for better UX Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Johan-Liebert1
force-pushed
the
some-changes
branch
from
July 15, 2026 06:49
5c2bdaa to
3849c36
Compare
jeckersb
reviewed
Jul 15, 2026
jeckersb
left a comment
jeckersb
left a comment
Collaborator
There was a problem hiding this comment.
I think dump_files as a public API would be more generally useful if it returned an Iterator that yielded the dumped representation of each file. Then in the DumpFiles command we can just iterate and print it. But library users will have the actual dump data available.
Collaborator
Library users can already operate on the in-memory filesystem representation directly I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
clap: Show usage and suggestions
Add features "error-context" and "suggestions" to show suggestions on
incorrect command usage
Before
After
cfsctl: Make
dump_filespublicUseful in bootc to get backing path. Also update the signature to take
in a repository and an image name for better UX