Skip to content

lisa/feat-ai-diagnostics#266

Merged
gusfcarvalho merged 7 commits into
mainfrom
lisa/feat-ai-diagnostics
Jun 18, 2026
Merged

lisa/feat-ai-diagnostics#266
gusfcarvalho merged 7 commits into
mainfrom
lisa/feat-ai-diagnostics

Conversation

@ccf-lisa

@ccf-lisa ccf-lisa Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

automated implementation by lisa.

@gusfcarvalho gusfcarvalho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings inline — all non-blocking nits. CI is green (test + type-check), formatting is clean, and the prior self-review findings are genuinely addressed. Nice separation (composable/partials/view), fail-closed error handling, correct camelcaseStopPaths label-key preservation, and a guarded pagination request. Three small items: a redundant double refreshAll on first load, a notifications-health deep link whose hash doesn't open the panel, and a no-op data.cells.labelSets stop-path.

Comment thread src/views/admin/AiDiagnosticsView.vue
Comment thread src/views/admin/AiDiagnosticsView.vue Outdated
Comment thread src/composables/useAiDiagnostics.ts Outdated

@gusfcarvalho gusfcarvalho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks — the three prior nits are all addressed in 5ea03f5 (cells.labelSets stop-path removed; notifications hash dropped + link text corrected; double refreshAll guarded with hasCompletedInitialConfigLoad). type-check is clean. One new blocking UX issue found in manual testing: the run-detail drawer is too narrow (pinned at ~320px by the volt theme's p-right:w-80), so the Cells table is cut off. Concrete fix inline — needs an !important width override on the drawer instance.

Comment thread src/views/admin/AiDiagnosticsView.vue Outdated

@gusfcarvalho gusfcarvalho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. All review findings addressed across 5ea03f5/564e423/80f024f: the 3 original nits (double refreshAll guard, notifications link/hash, no-op stop-path) plus the run-detail drawer width blocker — now w-screen! max-w-6xl!, which correctly overrides the volt p-right:w-80 specificity so the Cells table is usable. CI green (test + type-check), no unresolved threads. Nice work.

@ccf-lisa

ccf-lisa Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

PR approved. Marking as ready for e2e.

@gusfcarvalho gusfcarvalho merged commit 0fbf655 into main Jun 18, 2026
2 checks passed
@gusfcarvalho gusfcarvalho deleted the lisa/feat-ai-diagnostics branch June 18, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant