Skip to content

fix: dashboard fixes#265

Merged
gusfcarvalho merged 1 commit into
mainfrom
gc-fix-dashboard-suggestions-fixes
Jun 17, 2026
Merged

fix: dashboard fixes#265
gusfcarvalho merged 1 commit into
mainfrom
gc-fix-dashboard-suggestions-fixes

Conversation

@gusfcarvalho

@gusfcarvalho gusfcarvalho commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Enhanced failure reporting for suggestion runs with per-cell failure details and counts.
    • Improved suggestion grouping to better organize by proposed filters.
  • Bug Fixes

    • Fixed API payload formatting to prevent backend errors during scope selection.
    • Corrected suggestion reasoning display to show clearer, consolidated messaging.
  • Tests

    • Added test coverage for suggestion run failures and warning notifications.
    • Added verification for API payload transformation in scope previews.

Signed-off-by: Gustavo Carvalho <gustavo.carvalho@container-solutions.com>
@gusfcarvalho gusfcarvalho enabled auto-merge (squash) June 17, 2026 12:56
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

Refactors suggestion run failure modeling from a failures array to a stats.failedCells structure with new SuggestionRunCellFailure/SuggestionRunStats types. Adds formatRunFailureDetail for human-readable toast messages distinguishing full vs. partial failures. Rewrites pending suggestion grouping to use proposedFilterLabelSet, simplifies reasoning to a single field, and fixes the scope preview request to serialize keys via decamelizeKeys.

Changes

Suggestion Run Failures, Pending Grouping, and Reasoning Display

Layer / File(s) Summary
Data model: SuggestionRun stats, cell failures, DashboardSuggestion shape
src/views/dashboard/partials/dashboard-suggestions.ts
Adds SuggestionRunCellFailure and SuggestionRunStats interfaces; replaces SuggestionRun.failures with SuggestionRun.stats; exports runCellFailures helper; adds proposedFilterLabelSet to DashboardSuggestion and removes controlFitReasoning/systemRelevanceReasoning.
Failure formatting and poller toast logic
src/composables/useDashboardSuggestions.ts, src/composables/__tests__/useDashboardSuggestions.spec.ts
Imports runCellFailures; extends camelcaseStopPaths for proposedFilterLabelSet in both pending and historical fetches; adds formatRunFailureDetail producing semicolon-separated per-cell strings with an "and N more" suffix; updates terminal toast to show warn on partial cell failures vs. error on full failure. Test asserts the warning toast detail and that the success toast is suppressed when cells fail.
SuggestionsView failure display and pending grouping
src/views/dashboard/SuggestionsView.vue, src/views/dashboard/__tests__/SuggestionsView.spec.ts
Updates imports; replaces the failure block with per-cell runCellFailures rendering; simplifies reasoning UI to a single suggestion.reasoning field; rewrites pendingGroups to key by proposedFilterLabelSet via proposedFilterKey/evidenceMatchingFilter; removes failureKey. Tests update mock reasoning fields and verify grouping by proposed filter label set.

SuggestionScopeDialog Scope Payload Serialization

Layer / File(s) Summary
decamelizeKeys in preview request and test
src/views/dashboard/partials/SuggestionScopeDialog.vue, src/views/dashboard/partials/__tests__/SuggestionScopeDialog.spec.ts
Imports decamelizeKeys and applies it as Axios transformRequest in the scope preview POST so keys reach the backend in kebab-case. Test mock adds decamelizeKeys and a new case asserts transformRequest is defined on the request call.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Poem

🐇 Hoppity-hop through the cells that failed,
A runCellFailures path newly trailed!
Three errors shown, then "and N more" we say,
proposedFilterLabelSet groups the day.
Keys decamelized before they take flight—
The dashboard suggestions are working just right! 🥕

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'fix: dashboard fixes' is vague and redundant, using generic phrasing that doesn't convey the specific changes made (suggestion failure handling, reasoning refactoring, filter grouping). Revise the title to be more specific about the primary change, such as 'fix: improve dashboard suggestion failure handling and reasoning display' or 'fix: refactor suggestion run failures and proposed filter grouping'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gusfcarvalho gusfcarvalho merged commit 23c26f1 into main Jun 17, 2026
2 of 3 checks passed
@gusfcarvalho gusfcarvalho deleted the gc-fix-dashboard-suggestions-fixes branch June 17, 2026 12:59
@coderabbitai coderabbitai Bot mentioned this pull request Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant