Skip to content

[test] Disable flaky leakcheck tests, as done in ROOT's cppyy #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronj0 merged 1 commit into from
Sep 7, 2026
Merged

[test] Disable flaky leakcheck tests, as done in ROOT's cppyy #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions test/test_leakcheck.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import sys

from pytest import mark, skip
from support import IS_MAC, IS_MAC_X86

nopsutil = False
try:
Expand All @@ -11,7 +10,7 @@
nopsutil = True


@mark.skipif(nopsutil == True, reason="module psutil not installed")
@mark.skip(reason="disabled due to its sporadic nature, especially fragile on VMs")
class TestLEAKCHECK:
def setup_class(cls):
import psutil
Expand Down Expand Up @@ -75,9 +74,6 @@ def check_func(self, scope, func, *args, **kwds):

assert fail < M

@mark.xfail(
condition=IS_MAC, reason="std::string overload fails to resolve on OS X"
)
def test01_free_functions(self):
"""Leak test of free functions"""

Expand All @@ -103,9 +99,6 @@ def test01_free_functions(self):
self.check_func(ns, "free_f_ret1")
self.check_func(ns, "free_f_ret1")

@mark.xfail(
condition=IS_MAC, reason="std::string overload fails to resolve on OS X"
)
def test02_test_static_methods(self):
"""Leak test of static methods"""

Expand All @@ -132,9 +125,6 @@ class MyClass02 {
self.check_func(m, "static_method_ol", 42.0, tmpl_args="float")
self.check_func(m, "static_method_ret")

@mark.xfail(
condition=IS_MAC, reason="std::string overload fails to resolve on OS X"
)
def test03_test_methods(self):
"""Leak test of methods"""

Expand Down Expand Up @@ -264,11 +254,6 @@ class Leaker {
obj = ns.Leaker()
self.check_func(obj, "leak_string", 2048)

@mark.xfail(
condition=IS_MAC_X86,
strict=False,
reason="RSS threshold intermittently trips on the Intel-mac runners",
)
def test08_list_creation(self):
"""Leak check of creating a python list from an std::list"""

Expand Down
Loading