[pull] develop from lammps:develop - #170
Merged
Merged
Conversation
Implements the feature requested in issue #5087. The lo/hi positions of the xplane/yplane/zplane wall styles may now be given as v_name equal-style variables. Since damping and friction in granular contact models depend on the relative velocity between particle and wall, a wall with a position variable must also be given its velocity through the new 'vel' keyword (constant or equal-style variable per wall); no finite differencing of positions is done. Each particle uses the velocity of its nearer wall. Also: collapse the triplicated plane parsing in the constructor, stop with an error when the lo wall does not remain below the hi wall, and bracket all variable evaluations (including the pre-existing wall temperature one, also in fix wall/gran/region) with clearstep/addstep_compute so variables may reference computes. The KOKKOS version (which still derives from the frozen pre-GranularModel implementation) reports a specific error message when a wall position variable or the vel keyword is used. fix wall/gran/region does not need this feature since regions provide their own motion, including velocity.
…keyword For consistency with how moving regions handle motion variables (see Region::set_velocity(), used by fix wall/gran/region), infer the velocity of a wall with a position variable from the change of the wall position between consecutive timesteps and drop the vel keyword again. The velocity is zero at the very first evaluation and re-evaluations on the same timestep (setup of a continued run) keep the previous velocity, mirroring the vel_timestep guard of regions.
Use delete[] on the target location before (re-)assigning the result of utils::strdup(), following the convention used for all other copied names (variables, regions, groups) after the recent Coverity scan cleanup.
Allow setting fix wall/gran wall positions via equal-style variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )