Repository navigation
Run the broker wait script with uv - #208
Merged
Merged
Conversation
The recipe used the ambient python3, which is 3.9 on macOS and can't run the script's dataclass(slots=True). Every other recipe already goes through uv, and the project interpreter satisfies requires-python.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just testruns the broker readiness probe with the ambient interpreter:scripts/wait_for_stomp_brokers.pydeclares@dataclass(frozen=True, slots=True), andslots=Truerequires Python 3.10. On macOSpython3is/usr/bin/python3, which is 3.9.6, so the script dies withTypeError: dataclass() got an unexpected keyword argument 'slots'before probing anything. Withset -euo pipefailthe recipe then aborts and theEXITtrap tears the containers down, sojust testcan never reach pytest.CI doesn't see it, because
ubuntu-latestships a modernpython3. It only affects contributors whose systempython3predates 3.10 — andjust testis what AGENTS.md tells them to run for integration tests.uv run pythonpins the call to the project interpreter, which satisfiesrequires-python = ">=3.11"by construction, and matches every other recipe in the Justfile (uv run pytest,uv run mypy,uv run ruff). The script is stdlib-only, so this is about the interpreter version, not about dependencies.Verified with
just teston macOS: the probe printsActiveMQ Artemis is ready on 127.0.0.1:9000and the suite runs to 476 passed, 1 skipped.